8000 Fix: Port forward of by fsbraun · Pull Request #7694 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

Fix: Port forward of #7694

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 192 commits into from
Closed

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Nov 20, 2023

Description

This PR ports forward 2 fixes for v3 also relevant for v4.

Also, it resolves an issue with the GitHub actions, which used to always run against Django==3.2.16.

Related resources

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

vxsx and others added 30 commits June 13, 2018 12:48
* Update apphooks.rst

You need to add *Application instance name* by hand to a page when you add an ``app_name`` #hopeitsavessomeoneelsethetrouble

* Changed as per czpython's suggestions

While still trying to convey that we're fixing the same problem than the previous paragraphs refers to (and that *Application instance name* only appears after setting ``app_name`` )
…All" button

Conflicts:
	cms/static/cms/js/dist/3.5.2/bundle.toolbar.min.js
Replaced treebeard with absolute position field on CMSPlugin model
fsbraun and others added 27 commits June 27, 2023 14:08
* Fix: Complete styling of action buttons

* feat: color-scheme/dark-mode for v4

* Fix toolbar tests to reflect dark mode switch

* fix test_views

* Remove outdated sun/moon icons

* Update cms/static/cms/sass/components/_sideframe.scss

Co-authored-by: Mark Walker <theshow@gmail.com>

* Fix: z-index issue

* Remove escapejs not needed

* Fix shortcuts dark-mode

* Dark-mode for `<kbd>` tag in shortcuts

* Remove double-styling

---------

Co-authored-by: Mark Walker <theshow@gmail.com>
…django-cms#7599)

* Fix: Complete styling of action buttons

* Update karma in package.json to current version

* Update babel-core

* Undo unwanted scss changes

* Remove webpack2 polyfill plugin (promise polyfill)

* Test using chrome headless

* Use Chrome instead of Chrome Headless

* Run headless chrome

* fix eslint issues

* Update supporting libs
…ion (django-cms#7613)

* fix: Cross-talk between grouper admins due to common initial list

* Add: Fix styling with plain Django

* Fix: Focus on first non-language selector input in change form
…jango-cms#7604)

* fix: remove copy_to_public from page and page content extensions

* Fix: Make `copy_to_public` a no-op issuing a warning
fix: Pull transifex strings from base directory when building a release
* Support for Django 5.0

* Fix: test.yml and django Promise handling

* Shorten github action names

* Update test.yml

* Update _cms.scss

* Update setup.py
* ci: Add testing against django main branch

* ci: Add dependabot github action updates

* ci: Test all dbs on django main

* Update postgres

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Output django version

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Output django version

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* ci: install requirements before django

* Remove duplicate

Co-authored-by: Fabian Braun <fsbraun@gmx.de>

* Replace get_storage_class with import_string

* Fix ruff

* remove unused code from util. __init__.py

* Fix incomplete property overwrite

* Fix: Lazy choice field implementation was wrong. Added test coverage

* Fix: Add `on-error-continue: true` to django-main-postgres and django-main-mysql github actions

---------

Co-authored-by: Fabian Braun <fsbraun@gmx.de>
… page template (django-cms#7671)

* Fix: add .current_page to request for structure board

* Fix caching issue showing wrong selected page template

* Fix: add .current_page to request for structure board

* Fix caching issue showing wrong selected page template

* Add tests

* fix: Update RTD config (django-cms#7647)

* Add comments

---------

Co-authored-by: Mark Walker <mark@django-cms.org>
…actions (django-cms#7680)

* fix: django-cms#7662, add support for python 3.12 and upgrade github actions

* fix: deprecations

* fix: make some improvements to codespell and the tests for docs

* fix: add updated reqs for docs

* fix: code spell typos

* fix: code spell typos for docs

* fix: some more spell fixes

* fix: pretty much all spelling mistakes

* fix: some more spelling mistakes

* fix: skiplist further

* fix: issue with outdated deps at docs/requirements

* fix: downgrade matplotlib to a version that also builds on python 3.8

* fix: 3.8 build

* fix: try to fix some test failures

* fix: drop 3.8

* fix: upgrade sphinxcontrib-spelling to 8.0.0 so that 3.12 builds

* fix: no need to hardcode sphinx in test requirements

* fix: get the tests passing for sqlite

* fix: sqlite tests finally

* fix: use furo theme for cms 4 as well

:

* fix: use cms 4 for building docs documentation

* fix: same as in develop for cms 3.11.x

* fix: abbreviation into full form to not confused codespell
…ngo-cms#7679)

* Fix: `.load` jQuery method erroneously replaced by `on('load')`

* fix: Remove `can_publish` permission from django CMS 4 core (django-cms#7635)

* Fix css glitch

* Update translations source fill which was missing strings

* Fix: Remove can_publish permission

* Update _toolbar.scss

* Fix: Use svg icons for boolean values in admin (present since Dango 1.11)

* Fix: Update to use .format for icon base

* Fix: missing alt attribute
@fsbraun fsbraun requested a review from marksweb November 20, 2023 07:26
@fsbraun fsbraun added the 4.1 label Nov 20, 2023
@fsbraun fsbraun closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

0