8000 fix: Pull transifex strings from base directory when building a release by fsbraun · Pull Request #7623 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

fix: Pull transifex strings from base directory when building a release #7623

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 17 commits into from
Aug 9, 2023

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Aug 9, 2023

Description

Currently, they are pulled from the cms directory leading to a "no found" error and effectively ignoring any new translations.

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

fsbraun and others added 16 commits December 30, 2022 19:06
* [4.1.0rc1 release process] Building locales
* [4.1.0rc1 release process] Bumped version to 4.1.0rc1
* [4.1.0rc1 release process] compiling new static files
* [4.1.0rc1 release process] updating latest docs
* Update CHANGELOG.rst
* Add: publish release actions
build: merge `develop-4` into `release/4.1.x`
* [4.1.0rc2 release process] Building locales

* [4.1.0rc2 release process] Bumped version to 4.1.0rc2

* [4.1.0rc2 release process] compiling new static files

* [4.1.0rc2 release process] updating latest docs

* Update README.rst

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>
* [4.1.0rc3 release process] Bumped version to 4.1.0rc3

* [4.1.0rc3 release process] compiling new static files

* [4.1.0rc3 release process] updating latest docs

* Update CHANGELOG.rst

---------

Co-authored-by: Github Release Action <info@django-cms.org>
@fsbraun fsbraun requested a review from marksweb August 9, 2023 08:15
@fsbraun fsbraun added the 4.1 label Aug 9, 2023
Copy link
Member
@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted! 👍

@fsbraun fsbraun merged commit d71555a into django-cms:develop-4 Aug 9, 2023
@fsbraun fsbraun deleted the fix/transifex-pull branch January 10, 2025 19:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0