-
-
Notifications
You must be signed in to change notification settings - Fork 3.2k
fix: Pull transifex strings from base directory when building a release #7623
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [4.1.0rc1 release process] Building locales * [4.1.0rc1 release process] Bumped version to 4.1.0rc1 * [4.1.0rc1 release process] compiling new static files * [4.1.0rc1 release process] updating latest docs * Update CHANGELOG.rst * Add: publish release actions
build: merge `develop-4` into `release/4.1.x`
* [4.1.0rc2 release process] Building locales * [4.1.0rc2 release process] Bumped version to 4.1.0rc2 * [4.1.0rc2 release process] compiling new static files * [4.1.0rc2 release process] updating latest docs * Update README.rst * Update CHANGELOG.rst --------- Co-authored-by: Github Release Action <info@django-cms.org>
…jango-cms#7552) * Fix empty actions * Add tests * Fix tests
* [4.1.0rc3 release process] Bumped version to 4.1.0rc3 * [4.1.0rc3 release process] compiling new static files * [4.1.0rc3 release process] updating latest docs * Update CHANGELOG.rst --------- Co-authored-by: Github Release Action <info@django-cms.org>
build: Version 4.1rc3
marksweb
approved these changes
Aug 9, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Well spotted! 👍
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, they are pulled from the
cms
directory leading to a "no found" error and effectively ignoring any new translations.Related resources
Checklist
develop-4