10000 fix: try to upgrade node.js to 18 by vinitkumar · Pull Request #7601 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: try to upgrade node.js to 18 #7601

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2023
Merged

fix: try to upgrade node.js to 18 #7601

merged 1 commit into from
Jun 30, 2023

Conversation

vinitkumar
Copy link
Member
@vinitkumar vinitkumar commented Jun 30, 2023 •
edited
Loading

Description

Upgrade the Node.js to 18 LTS version.

Checklist

  • I have opened this pull request against develop
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@vinitkumar vinitkumar requested a review from fsbraun June 30, 2023 16:33
@vinitkumar vinitkumar added the 4.1 label Jun 30, 2023
marksweb
marksweb approved these changes Jun 30, 2023
View reviewed changes
Copy link
Member
@marksweb marksweb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good if the frontend checks are to be believed 👍

@fsbraun fsbraun merged commit a0977a7 into django-cms:develop-4 Jun 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

@fsbraun fsbraun fsbraun approved these changes

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@vinitkumar @marksweb @fsbraun
0