10000 Register Placeholder model with admin by Aiky30 · Pull Request #6458 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Register Placeholder model with admin #6458

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jul 26, 2018
Merged

Register Placeholder model with admin #6458

merged 3 commits into from
Jul 26, 2018

Conversation

Aiky30
Copy link
Contributor
@Aiky30 Aiky30 commented Jul 25, 2018

Documentation checklist

  • I have updated CHANGELOG.txt if appropriate
  • I have updated the release notes document if appropriate, with:
    • general notes
    • bug-fixes
    • improvements/new features
    • backwards-incompatible changes
    • required upgrade steps
    • names of contributors
  • I have updated other documentation
  • I have added my name to the AUTHORS file
  • This PR's documentation has been approved by Daniele Procida

@coveralls
Copy link
coveralls commented Jul 25, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 78.189% when pulling 7327523 on Aiky30:placeholder-admin into 1d78946 on divio:release/4.0.x.

czpython
czpython suggested changes Jul 25, 2018
View reviewed changes
Copy link
Contributor
@czpython czpython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing permission methods to prevent placeholder from actually showing up on the admin.

@czpython czpython merged commit 5a1c893 into django-cms:release/4.0.x Jul 26, 2018
@czpython czpython self-assigned this Jul 26, 2018
@czpython czpython added this to the 4.0.0 milestone Jul 26, 2018
@Aiky30 Aiky30 deleted the placeholder-admin branch July 27, 2018 09:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@czpython czpython czpython approved these changes

Assignees

@czpython czpython

Labels
status: accepted
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Aiky30 @coveralls @czpython
0