8000 Remove Publish button from the toolbar by Aiky30 · Pull Request #6414 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Remove Publish button from the toolbar #6414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 14, 2018
Merged

Remove Publish button from the toolbar #6414

merged 2 commits into from
Jun 14, 2018

Conversation

Aiky30
Copy link
Contributor
@Aiky30 Aiky30 commented Jun 13, 2018 •
edited
Loading

Summary

Remove the publish button from the toolbar and fix any failing tests.

Links to related discussion

Documentation is not publicly available.

Proposed changes in this pull request

Removed the call to create the button.
Removed the method that adds the publish button to the toolbar.
Removed two tests that check for the toolbar publish button.
Removed redundant import statements due to removal of code.

Documentation checklist

  • I have updated CHANGELOG.txt if appropriate
  • I have updated the release notes document if appropriate, with:
    • general notes
    • bug-fixes
    • improvements/new features
    • backwards-incompatible changes
    • required upgrade steps
    • names of contributors
  • I have updated other documentation
  • I have added my name to the AUTHORS file
  • This PR's documentation has been approved by Daniele Procida

@czpython czpython self-assigned this Jun 13, 2018
@czpython czpython added this to the 4.0.0 milestone Jun 13, 2018
@Aiky30
Copy link
Contributor Author
Aiky30 commented Jun 13, 2018 •
edited
Loading

HI Vladim ( @vxsx ),
Can you help me get the FE tests passing in this pull request please. I have added yourself and Paulo ( @czpython ) as collaborators to my forked repository.
Thank you,
Andrew

@coveralls
Copy link
coveralls commented Jun 13, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 78.18% when pulling 8f302d8 on Aiky30:publish-button into 44dbb08 on divio:release/4.0.x.

@czpython czpython changed the base branch from develop to release/4.0.x June 13, 2018 15:07
@vxsx vxsx force-pushed the publish-button branch from c224a78 to 8f302d8 Compare June 14, 2018 06:15
@vxsx
Copy link
Contributor
vxsx commented Jun 14, 2018

@Aiky30 all the test depends in some way on publishing pages, it will take some time to adapt them and the djangocms-casper-helpers library (especially since more changes to publishing will come, so to speak) so for now we decided to allow them to fail. I will likely have time next week to look deeper into them, but for now I've rebased the branch on top of latest release/4.0.x that has #6415 in.

@czpython czpython merged commit 41c4ab0 into django-cms:release/4.0.x Jun 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@czpython czpython

Labels
status: accepted
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.
4 participants
@Aiky30 @coveralls @vxsx @czpython
0