Remove logic which publishes the first page page as soon as it is created #6446
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
- Remove logic in forms which publishes the first page of a site
- Remove tests that check for this
czpython
suggested changes
Jul 13, 2018
cms/test_utils/testcases.py
Outdated
| @@ -265,6 +265,7 @@ def get_new_page_data(self, parent_id=''): | |||
| 'title': 'test page %d' % self.counter, | |||
| 'slug': 'test-page-%d' % self.counter, | |||
| 'parent_node': parent_id, | |||
| 'publish': True, # Temp added as most tests require the first page to be published | |||
There was a problem hiding this comment.
this is not a field on the form, is not used.
czpython
approved these changes
Jul 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.