fix: remove copy_to_public from page and page content extensions
#7604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
As indicated in django-cms/djangocms-versioning#342
ExtensionBase(base class for bothPageExtensionandPageContentExtension) still has acopy_to_publicmethod.This PR removes it from the model and adjusts the signatures of affected private methods accordingly.
It thereby removes a remnant of the version 3 draft/public predecessor of v4's versioning.
The removed lines of code were not covered by tests. The remaining lines are.
This PR breaks third-party code that use
copy_to_publicthemselves. This is a feature in my opinion since it uncovers the third-parties interference with publishing which will not work in v4.Related resources
Checklist
develop-4