Remove revert to live feature #6454
Conversation
| return False | ||
|
|
||
| site = self.get_site(request) | ||
| has_perm = page_permissions.user_can_revert_page_to_live( |
There was a problem hiding this comment.
when doing these kinds of removals, make sure to also remove the function being called (if not used anywhere else). So in this case remove user_can_revert_page_to_live and if there's a permission attached to it, also remove that.
There was a problem hiding this comment.
@czpython I have done as you requested. In this instance the permission is also used elsewhere in the file so I believe that the permission should stay. Let me know if I've misunderstood. Ta.
There was a problem hiding this comment.
Just spotted and removed a redundant new line. Will need to let it build and pass. It was a pass before this change so I don't see any issues with it going ahead.
There was a problem hiding this comment.
Which permission are you referring to?
There was a problem hiding this comment.
@czpython you mentioned "if there's a permission attached to it, also remove that.". There was a decorator with a permission label which is used in other parts. I figured you were referring to that.
There was a problem hiding this comment.
-@auth_permission_required('change_page')
Summary
Remove revert to live from toolbar
Remove tests for this feature
Remove revert_to_live method on Page model
Documentation checklist