10000 Moved placeholders from Page to Title model by Aiky30 · Pull Request #6442 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

Moved placeholders from Page to Title model #6442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 21 commits into from
Jul 12, 2018
Merged

Moved placeholders from Page to Title model #6442

merged 21 commits into from
Jul 12, 2018

Conversation

Aiky30
Copy link
Contributor
@Aiky30 Aiky30 commented Jul 10, 2018

Move the placeholders many to many field from the Page model to the Title model
Adjust any failing tests
Do not introduce new tests
Create a data migration to:

  • Create a placeholder for each language the page is tied to (title_set)
  • Move all plugins for each language into their respective placeholder

@coveralls
Copy link
coveralls commented Jul 10, 2018 •
edited
Loading

Coverage Status

Coverage remained the same at 78.189% when pulling 57b00f1 on Aiky30:placeholder-to-title into c8f56a9 on divio:release/4.0.x.

@czpython czpython self-assigned this Jul 11, 2018
@czpython czpython added this to the 4.0.0 milestone Jul 11, 2018
@czpython czpython changed the title Change the Placeholder M2M relationship from Page to Title Moved placeholders from Page to Title model Jul 11, 2018
Andrew Aikman and others added 21 commits July 11, 2018 13:19
@czpython
Added start of migrations
1100f55
@czpython
Move th eplaceholder field from the page to the title model
18b8870
@czpython
Moving the page placeholder models over to title
7e3b972
@czpython
Title -> Placeholder migrations working succesfully
5f662f4
@czpython
Cleaned the migrations
194402b
@czpython
Delete all page models titles placeholders on page delte
b64e790
@czpython
Update the failures on the page tests
c2fa474
@czpython
Continued repairing tests
0334681
@czpython
Fixed minor issues in the page admin tests
3afdf96
@czpython
Recent changes to make tests pass
fa4279e
@czpython
Cleanup
ab8df9c
@czpython
Refactor how tests fetch the pages placeholders
0e51ad9
@czpython
Fix typo in previous commit
8000
ed84828
@czpython
Continued fixing tests ensuring the placeholders are fetched properly
758fb2b
@czpython
Down to 27Errors and 19 test failures
4ef4820
@czpython
Reduced the failures and errors to 20/20
ea9bf3b
@czpython
fixed a few more tests including the test_nested_plugins
c9eec48
@czpython
more test fixes
8755eb9
@czpython
more adjustments
30c979e
@czpython
performance tests 1
817f0e8
@czpython
refactored migrations
57b00f1
@czpython czpython force-pushed the placeholder-to-title branch from a4c2854 to 57b00f1 Compare July 12, 2018 01:55
@czpython czpython merged commit 37082d0 into django-cms:release/4.0.x Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@czpython czpython

Labels
kind: enhancement status: accepted
Projects
None yet
Milestone
4.0.x
Development

Successfully merging this pull request may close these issues.
3 participants
@Aiky30 @coveralls @czpython
0