8000 fix: Remove second cancel button from modal by fsbraun · Pull Request #7603 · django-cms/django-cms · GitHub
[go: up one dir, main page]
Skip to content

fix: Remove second cancel button from modal #7603

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 4, 2023
Merged

fix: Remove second cancel button from modal #7603

merged 1 commit into from
Jul 4, 2023

Conversation

fsbraun
Copy link
Member
@fsbraun fsbraun commented Jul 3, 2023

Description

Some admin views provide their own cancel button. This PR removes it from the modal, since it has its own cancel button.

This is especially true for V4 packages. This is an example from versioning (see three modal buttons):

image

Related resources

  • #...
  • #...

Checklist

  • I have opened this pull request against develop-4
  • I have added or modified the tests when changing logic
  • I have followed the conventional commits guidelines to add meaningful information into the changelog
  • I have read the contribution guidelines and I have joined #workgroup-pr-review on Slack to find a “pr review buddy” who is going to review my pull request.

@fsbraun fsbraun requested a review from a team July 3, 2023 22:58
@fsbraun fsbraun added the 4.1 label Jul 3, 2023
@fsbraun fsbraun merged commit 5caf8d5 into django-cms:develop-4 Jul 4, 2023
@fsbraun fsbraun deleted the fix/cancel-button branch August 8, 2023 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marksweb marksweb marksweb approved these changes

Assignees
No one assigned
Labels
4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsbraun @marksweb
0