Remove default plugin creation #6468
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
czpython
suggested changes
Aug 6, 2018
docs/reference/configuration.rst
Outdated
| @@ -197,14 +197,6 @@ Example:: | |||
| 'extra_context': {"width":640}, | |||
| 'name': gettext("Content"), | |||
| 'language_fallback': True, | |||
cms/tests/test_placeholder.py
Outdated
| @@ -499,8 +492,8 @@ def test_get_placeholder_conf(self): | |||
| returned = get_placeholder_conf('excluded_plugins', 'main', 'layout/other.html') | |||
| self.assertEqual(returned, TEST_CONF['layout/other.html main']['excluded_plugins']) | |||
| # test grandparent inherited value | |||
| returned = get_placeholder_conf('default_plugins', 'main', 'layout/other.html') | |||
| self.assertEqual(returned, TEST_CONF['main']['default_plugins']) | |||
| returned = get_placeholder_conf('language_fallback', 'main', 'layout/other.html') | |||
There was a problem hiding this comment.
language_fallback was removed
db3ee71 to
e9c4ecb
Compare
czpython
approved these changes
Aug 6, 2018
4 tasks
4 tasks
fsbraun
added a commit
to fsbraun/django-cms
that referenced
this pull request
May 14, 2024
…ngo-cms#6468)"" This reverts commit 71f0d7f.
vinitkumar
pushed a commit
that referenced
this pull request
May 24, 2024
…nt) (#7928) * Revert "Removed default plugin creation for placeholders (#6468)" This reverts commit eef5cbb. * Fix: Only change structure board endpoint in edit mode * Fix typo * Revert "Revert "Removed default plugin creation for placeholders (#6468)"" This reverts commit 71f0d7f. * fix: Correct patch * Update cms.structureboard.js
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Based on #6460. Removed logic to create default plugins when placeholder is empty.
Documentation checklist