8000 Remove mentions of language_fallback · django-cms/django-cms@e9c4ecb · GitHub
[go: up one dir, main page]

Skip to content

Commit e9c4ecb

Browse files
author
Krzysztof Socha
committed
Remove mentions of language_fallback
1 parent 28da74b commit e9c4ecb

File tree

3 files changed

+4
-14
lines changed

3 files changed

+4
-14
lines changed

cms/tests/test_placeholder.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -457,7 +457,7 @@ def test_get_placeholder_conf(self):
457457
'main': {
458458
'name': 'main content',
459459
'plugins': ['TextPlugin', 'LinkPlugin'],
460-
'language_fallback': False,
460+
'require_parent': False,
461461
},
462462
'layout/home.html main': {
463463
'name': u'main content with FilerImagePlugin and limit',
@@ -492,8 +492,8 @@ def test_get_placeholder_conf(self):
492492
returned = get_placeholder_conf('excluded_plugins', 'main', 'layout/other.html')
493493
self.assertEqual(returned, TEST_CONF['layout/other.html main']['excluded_plugins'])
494494
# test grandparent inherited value
495-
returned = get_placeholder_conf('language_fallback', 'main', 'layout/other.html')
496-
self.assertEqual(returned, TEST_CONF['main']['language_fallback'])
495+
returned = get_placeholder_conf('require_parent', 'main', 'layout/other.html')
496+
self.assertEqual(returned, TEST_CONF['main']['require_parent'])
497497
# test generic configuration
498498
returned = get_placeholder_conf('plugins', 'something')
499499
self.assertEqual(returned, TEST_CONF[None]['plugins'])

cms/tests/test_rendering.py

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -668,7 +668,6 @@ def test_inherit_placeholder_override(self):
668668
r = self.render(self.test_page5)
669669
self.assertEqual(r, u'|' + self.test_data5['text_main'] + '|' + self.test_data5['text_sub'])
670670

671-
@override_settings(CMS_PLACEHOLDER_CONF={None: {'language_fallback': False}})
672671
def test_inherit_placeholder_queries(self):
673672
with self.assertNumQueries(FuzzyInt(6,8)):
674673
r = self.render(self.test_page2)

docs/reference/configuration.rst

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -196,7 +196,6 @@ Example::
196196
'text_only_plugins': ['LinkPlugin'],
197197
'extra_context': {"width":640},
198198
'name': gettext("Content"),
199-
'language_fallback': True,
200199
'child_classes': {
201200
'TextPlugin': ['PicturePlugin', 'LinkPlugin'],
202201
},
@@ -280,11 +279,6 @@ matches; if the same configuration is retrieved for the ``content`` placeholder
280279
this placeholder regardless of type (takes precedence over the
281280
type-specific limits).
282281

283-
``language_fallback``
284-
When ``True``, if the placeholder has no plugin for the current language
285-
it falls back to the fallback languages as specified in :setting:`CMS_LANGUAGES`.
286-
Defaults to ``True`` since version 3.1.
287-
288282
``plugin_modules``
289283
A dictionary of plugins and custom module names to group plugin in the
290284
toolbar UI.
@@ -522,10 +516,7 @@ will redirect to the URL of the same page in the fallback language. If
522516
``False``, the content will be displayed in the fallback language, but there
523517
will be no redirect.
524518

525-
Note that this applies to the fallback behaviour of *pages*. Starting for 3.1 *placeholders*
526-
**will** default to the same behaviour. If you do not want a placeholder to follow a page's
527-
fallback behaviour, you must set its ``language_fallback`` to ``False``
528-
in :setting:`CMS_PLACEHOLDER_CONF`, above.
519+
Note that this applies to the fallback behaviour of *pages*.
529520

530521
type
531522
Boolean

0 commit comments

Comments
 (0)
0