8000 Removed unpublish button from toolbar by Aiky30 · Pull Request #6438 · django-cms/django-cms · GitHub
[go: up one dir, main page]

Skip to content

Removed unpublish button from toolbar #6438

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jul 12, 2018

Conversation

Aiky30
Copy link
Contributor
@Aiky30 Aiky30 commented Jul 9, 2018

Removed the unpublish features from the toolbar. No tests failed. The publish and unpublish buttons are still present on the page drop down in the toolbar.

@coveralls
Copy link
coveralls commented Jul 9, 2018

Coverage Status

Coverage remained the same at 78.189% when pulling 989313f on Aiky30:remove-unpublish-button into 0394153 on divio:release/4.0.x.

@czpython czpython self-assigned this Jul 11, 2018
@czpython czpython added this to the 4.0.0 milestone Jul 11, 2018
Copy link
Contributor
@czpython czpython left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are some unused methods like has_dirty_objects, please remove these as well

@Aiky30
Copy link
Contributor Author
Aiky30 commented Jul 11, 2018

@czpython I have updated and removed some of the unused functions. :-)

@czpython czpython changed the title Remove unpublish button Removed unpublish button from toolbar Jul 11, 2018
@czpython czpython merged commit 14110d0 into django-cms:release/4.0.x Jul 12, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0