8000 DOC: use notebook-style for plot_svm_anova.py by jayasuryajsk · Pull Request #22555 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC: use notebook-style for plot_svm_anova.py #22555

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 456 commits into from
Closed

DOC: use notebook-style for plot_svm_anova.py #22555

wants to merge 456 commits into from

Conversation

jayasuryajsk
Copy link
Contributor

No description provided.

glemaitre and others added 30 commits October 25, 2021 11:37
@glemaitre
MNT remove 1.1 changelog due to rebase conflict
9227162
@glemaitre
ae223ee
@jeremiedbb @ogrisel @glemaitre
FIX delete feature_names_in_ when refitting on a ndarray (scikit-lear…
cd927c0 
…n#21389)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@spikebh @glemaitre
DOC Ensures that OrthogonalMatchingPursuitCV passes numpydoc validati…
112ae4e 
…on (scikit-learn#21412)
@g4brielvs @glemaitre
DOC Ensures that PassiveAggressiveRegressor passes numpydoc validation (
14fda2f 
scikit-learn#21413)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@g4brielvs @glemaitre
DOC Ensures that LabelSpreading passes numpydoc validation (scikit-le…
d6e24ee 
…arn#21414)
@spikebh @ogrisel @glemaitre
DOC Ensures that MultiTaskElasticNetCV passes numpydoc validation (sc…
8971a19 
…ikit-learn#21405)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
DOC update the News section in website (scikit-learn#21417)
7737cb9
@glemaitre
Trigger wheel builder workflow: [cd build]
0d37891
@PSSF23 @glemaitre
FIX enable blank issue creation (scikit-learn#21044)
bfbb59f
@glemaitre
FIX improve error message for large sparse matrix input in LogisticRe…
f0e0922 
…gression (scikit-learn#21093)
@lorentzenchr @thomasjpfan
@ogrisel @glemaitre
FIX out of bound error in split_indices (scikit-learn#21130)
1b97932 

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@jjerphan @glemaitre
MNT Move DistanceMetric under metrics (scikit-learn#21177)
71ca247
@thomasjpfan @glemaitre
TST Adds numpydoc tests for functions (scikit-learn#21245)
6a8d82a
@ogrisel @glemaitre
FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info (sci…
14dfb26 
…kit-learn#21338)

* FIX set docstrings on sklearn.utils.fixes.threadpool_limits/info

* Skip threadpool_info/threadpool_limits docstring checks for now
@thomasjpfan @glemaitre
ENH Improves message for HTML repr when notebook is not trusted (scik…
653bf69 
…it-learn#21316)
@glemaitre
MNT fix changelog 1.0.1 (scikit-learn#21416)
85c7327
@MaggieChege @glemaitre
Fix doc issues for cluster_optics dbscan (scikit-learn#21419)
916c6b3 
Co-authored-by: ciku <maggie@hellotractor.com>
@alceballosa @thomasjpfan @glemaitre
DOC Added the meaning of the default=None case in SparsePCA (scikit-l…
96789a6 
…earn#21421)

Co-authored-by: Thomas J. Fan <thomasjpfan@gmail.com>
@arisayosh @glemaitre
DOC Ensures that max_error passes numpydoc validation (scikit-learn#2…
c32569f 
…1420)
@glemaitre
DOC Ensures that SpectralEmbedding passes numpydoc validation (scikit…
377f1e2 
…-learn#21411)

* DOC Ensures that SpectralEmbedding passes numpydoc validation

* Trim trailing whitespace

* Add space

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

* Remove space

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@chritter @glemaitre
DOC Ensures that linkage_tree passes numpydoc validation (scikit-lear…
84c4676 
…n#21424)

* DOC numpydoc removed linkage_tree from FUNCTION_DOCSTRING_IGNORE_LIST

* DOC numpydoc fixed linkage_tree func docstring
@iofall @arisayosh @glemaitre
Fix numpydoc format for sklearn.model_selection._validation.numpydoc_…
c2700f5 
…validation_cross_val_predict (scikit-learn#21433)

Co-authored-by: iofall <50991099+iofall@users.noreply.github.com>

Co-authored-by: arisayosh <15692997+arisayosh@users.noreply.github.com>
@gpablo6 @jmloyola @glemaitre
DOC Ensures that sklearn.cluster._kmeans.k_means passes numpydoc vali…
a1c3d87 
…dation (scikit-learn#21423)

Co-authored-by: Juan Martin Loyola <jmloyola@outlook.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@arisayosh @glemaitre
DOC Ensures that train_test_split passes numpydoc validation (scikit-…
0cee297 
…learn#21435)
@embandera @glemaitre
DOC Ensures that metrics.pairwise.euclidean_distances passes numpydoc…
a066721 
… validation (scikit-learn#21429)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@majauhar @miwojc @glemaitre
DOC Ensures that sklearn.utils.validation.indexable passes numpydoc v…
40d05f4 
…alidation (scikit-learn#21431)

Co-authored-by: miwojc <miwojc@protonmail.com>
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@genvalen @glemaitre
DOC Ensures that log_likelihood passes numpydoc validation (scikit-le…
ef60a68 
…arn#21438)
@genvalen @glemaitre
DOC Ensures that empirical_covariance passes numpydoc validation (sci…
11e7e36 
…kit-learn#21439)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@mohaseeb @glemaitre
Speeding up test_voting/test_gridsearch (scikit-learn#21422)
afdff17
lesteve and others added 22 commits December 25, 2021 12:26
@lesteve @glemaitre
CI Revert temporary 60.0.0 setuptools work-around (scikit-learn#22036)
f623af3
@glemaitre
DOC Correct wrong default value in check_scalar docstring (scikit-lea…
16ed088 
…rn#22032)
@glemaitre
CI temporary fix for setuptools and distutils in Windows (scikit-lear…
24fed55 
…n#22049)
@lesteve @glemaitre
DOC Improve Windows advanced install instructions (scikit-learn#22056)
670b2cc
@glemaitre
FIX correctly initialize precisions_cholesky_ in GaussianMixture (sci…
72d483d 
…kit-learn#22058)
@MaxwellLZH @glemaitre
ENH speed up test_unsupervised_model_fit (scikit-learn#22045)
10236a4 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@mandjevant @glemaitre
DOC svm add callable as accepted type for kernel parameter (scikit-le…
2cd3bfe 
…arn#21675)
@siavrez @glemaitre
DOC Update cross_validation.rst (scikit-learn#22066)
d3ec8f8
@siavrez @glemaitre
DOC Update cross_validation.rst (scikit-learn#22067)
c46ac60
@glemaitre @lorentzenchr
FIX Corrects negative gradient of AdaBoost loss in GBDT (scikit-learn…
3bb7286 
…#22050)

Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@TomDLT @ogrisel @glemaitre
FIX Isomap with precomputed distances and disconnected graph (scikit-…
4710a4a 
…learn#21915)

Co-authored-by: Olivier Grisel <olivier.grisel@ensta.org>
@djdrack @glemaitre
DOC Ensures randomized_range_finder passes numpydoc validation (sciki…
bd2ed7f 
…t-learn#22069)
@glemaitre
CI Fixes wheel building (scikit-learn#22051)
3773ee7
@thomasjpfan @glemaitre
FIX Improves feature names support for SelectFromModel + Est w/o names (
f952d92 
scikit-learn#21991)

Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
@glemaitre
FIX wrong conflict resolution
afa6333
@glemaitre
DOC update release date and bumpversion
063f72f
@glemaitre
DOC update list of authors
350bbf8
@glemaitre
DOC move fixes from 1.1 to 1.0.2 (scikit-learn#22070)
c7b02f5
@glemaitre
fix remove 1.1 log
4954a51
@thomasjpfan @glemaitre
DOC Move SVM parameter validation back to log 1.1 (scikit-learn#22072)
b72778d
@glemaitre
[cd build] Trigger CI/CD
7e1e6d0
@jayasuryajsk
Update plot_svm_anova.py
9bb7f0a
ArturoAmorQ
ArturoAmorQ reviewed Feb 24, 2022
View reviewed changes
examples/svm/plot_svm_anova.py
# Create a feature-selection transform, a scaler and an instance of SVM that we
# combine together to have a full-blown estimator
# %%
# Create a feature-selection transform, a scaler and an instance of SVM that we combine together to have a full-blown estimator
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line is too long. Try to follow the PEP 8 convention, i.e. try to limit all lines to a maximum of 79 characters.

examples/svm/plot_svm_anova.py
# Import some data to play with
# ------------------------------------------------
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# ------------------------------------------------
# ------------------------------------------------

Try to leave a blank line below this delimiter and the ones below

@cmarmo
Copy link
Contributor
cmarmo commented Feb 26, 2022

Hi @jayasuryajsk, thanks for your pull request. Something went wrong with your branching or pull request creation.
Do you mind opening a pull request to the main branch of the scikit-learn repo and not to the 1.0.X as it is done now?
You did it right in your previous pull request #22534.

@glemaitre glemaitre changed the base branch from 1.0.X to main March 9, 2022 10:39
@glemaitre
Copy link
Member

I was wondering if changing the branch tagged would be enough but it seems that it is not.
@jayasuryajsk Feel free to open a new PR to main.

@glemaitre glemaitre closed this Mar 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ArturoAmorQ ArturoAmorQ ArturoAmorQ left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0