8000 DOC Ensures that max_error passes numpydoc validation by arisayosh · Pull Request #21420 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Ensures that max_error passes numpydoc validation #21420

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 23, 2021
Merged

DOC Ensures that max_error passes numpydoc validation #21420

merged 1 commit into from
Oct 23, 2021

Conversation

arisayosh
Copy link
Contributor
@arisayosh arisayosh commented Oct 23, 2021 •
edited
Loading

Reference Issues/PRs

Addresses #21350

What does this implement/fix? Explain your changes.

  • remove sklearn.metrics._regression.max_error from scikit-learn/maint_tools/test_docstrings.py
  • fix numpydoc validation error in sklearn.metrics._regression.max_error

Any other comments?

cc (pair programming partner): @iofall

@arisayosh arisayosh changed the title DOC: fix numpydoc validation error in sklearn.metrics._regression.max_error DOC Ensures that sklearn.metrics._regression.max_error passes numpydoc validation Oct 23, 2021
@reshamas
Copy link
Member

#DataUmbrella sprint
cc: @nestornav

@amueller
Copy link
Member

Looks good if tests are passing :)

thomasjpfan
thomasjpfan approved these changes Oct 23, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thomasjpfan thomasjpfan changed the title DOC Ensures that sklearn.metrics._regression.max_error passes numpydoc validation DOC Ensures that max_error passes numpydoc validation Oct 23, 2021
@thomasjpfan thomasjpfan merged commit f93b97a into scikit-learn:main Oct 23, 2021
@arisayosh arisayosh deleted the numpydoc_validation branch October 23, 2021 20:46
@arisayosh
Copy link
Contributor Author

Amazing, thank you for reviewing @amuellar and @thomasjpfan. The sprint was such a fun learning experience! Thank you again!

@reshamas reshamas mentioned this pull request Oct 26, 2021
Closed
ogrisel pushed a commit to ogrisel/scikit-learn that referenced this pull request Oct 28, 2021
@arisayosh @ogrisel
DOC Ensures that max_error passes numpydoc validation (scikit-learn#2…
62d4bf1 
…1420)
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@arisayosh @samronsin
DOC Ensures that max_error passes numpydoc validation (scikit-learn#2…
96c2abd 
…1420)
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@arisayosh @glemaitre
DOC Ensures that max_error passes numpydoc validation (scikit-learn#2…
0e58319 
…1420)
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
@arisayosh @glemaitre
DOC Ensures that max_error passes numpydoc validation (#21420)
c32569f
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@amueller amueller amueller approved these changes

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:metrics Sprint
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@arisayosh @reshamas @amueller @thomasjpfan
0