8000 DOC svm add callable as accepted type for kernel parameter by mandjevant · Pull Request #21675 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC svm add callable as accepted type for kernel parameter #21675

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 23, 2021
Merged

DOC svm add callable as accepted type for kernel parameter #21675

merged 5 commits into from
Dec 23, 2021

Conversation

mandjevant
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

Documentation update for svm _classes file. Adds accepted type callable to parameter 'kernel'.
Previously, the accepted parameter type callable was only mentioned in the explanation. Not in the main line.

Any other comments?

@mandjevant
Copy link
Contributor Author

Could someone help me understand the build error?
It doesn't seem to me like the failure has anything to do with my changes.

@mandjevant
Copy link
Contributor Author

Nevermind. Seems like that is happening due to #21645

@mandjevant mandjevant mentioned this pull request Nov 23, 2021
Merged
thomasjpfan
thomasjpfan reviewed Nov 25, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @mandjevant !

@mandjevant
Copy link
Contributor Author

Again I don't think that it fails because of this PR.

thomasjpfan
thomasjpfan reviewed Nov 26, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The "It must be one of 'linear', 'poly', 'rbf', 'sigmoid', 'precomputed' or" appears in all the other diffs. I think they are all safe to remove.

@mandjevant
Copy link
Contributor Author

The "It must be one of 'linear', 'poly', 'rbf', 'sigmoid', 'precomputed' or" appears in all the other diffs. I think they are all safe to remove.

Sincerest apologies for missing this. The newest commit encapsulates the correct changes.

thomasjpfan
thomasjpfan approved these changes Nov 26, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@cmarmo
Copy link
Contributor
cmarmo commented Dec 15, 2021

Hi @mandjevant apparently there was some issue in the process of building the documentation. Do you mind synchronizing with upstream and pushing? This will render the documentation and help with the review. Thanks for your time.

@mandjevant
Copy link
Contributor Author

Hi @cmarmo sorry for the tardy response.
I merged and pushed. Verification is in progress.

@thomasjpfan thomasjpfan changed the title DOC svm _classes add callable as accepted type for parameter 'kernel' DOC svm add callable as accepted type for kernel parameter Dec 23, 2021
@thomasjpfan thomasjpfan merged commit 51174b7 into scikit-learn:main Dec 23, 2021
@mandjevant mandjevant deleted the svm_classes_kernel_docs branch December 23, 2021 13:55
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@mandjevant @glemaitre
DOC svm add callable as accepted type for kernel parameter (scikit-le…
d05ec93 
…arn#21675)
glemaitre pushed a commit that referenced this pull request Dec 25, 2021
@mandjevant @glemaitre
DOC svm add callable as accepted type for kernel parameter (#21675)
2cd3bfe
venkyyuvy pushed a commit to venkyyuvy/scikit-learn that referenced this pull request Jan 1, 2022
@mandjevant @venkyyuvy
DOC svm add callable as accepted type for kernel parameter (scikit-le…
80bc0a9 
…arn#21675)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:svm
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandjevant @cmarmo @thomasjpfan
0