8000 DOC Various doc update by mandjevant · Pull Request #21764 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC Various doc update #21764

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Nov 26, 2021
Merged

DOC Various doc update #21764

merged 7 commits into from
Nov 26, 2021

Conversation

mandjevant
Copy link
Contributor

Reference Issues/PRs

What does this implement/fix? Explain your changes.

  • DOC multiclass missing default parameter
  • DOC neighbors _nearest_centroid missing default parameter 'metric'
  • DOC change style of KBinsDiscretizer preprocessor to match other models
  • DOC change style of GaussianMixture to match other models
  • DOC add accepted str for parameter 'kernel' in kernel ridge. Previous reference to pairwise did not include 'precomputed'.

Any other comments?

Please also take a look at #21675 It has been open for a bit.

@mandjevant mandjevant changed the title Various doc update DOC Various doc update Nov 24, 2021
glemaitre
glemaitre reviewed Nov 25, 2021
View reviewed changes
Copy link
Member
@glemaitre glemaitre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise LGTM

mandjevant and others added 2 commits November 25, 2021 19:42
@mandjevant
Copy link
Contributor Author

All done.

@glemaitre Mind looking at #21675 for me too? It's been open for a while. Thanks!

thomasjpfan
thomasjpfan approved these changes Nov 25, 2021
View reviewed changes
Copy link
8000
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @mandjevant !

LGTM

@glemaitre glemaitre merged commit 231ca9e into scikit-learn:main Nov 26, 2021
@glemaitre
Copy link
Member

Thanks @mandjevant

glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Nov 29, 2021
@mandjevant @glemaitre
DOC Various documentation improvements (scikit-learn#21764)
cddbc6a 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
samronsin pushed a commit to samronsin/scikit-learn that referenced this pull request Nov 30, 2021
@mandjevant @glemaitre @samronsin
DOC Various documentation improvements (scikit-learn#21764)
97c5473 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@mandjevant @glemaitre
DOC Various documentation improvements (scikit-learn#21764)
5cdfea0 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
glemaitre added a commit that referenced this pull request Dec 25, 2021
@mandjevant @glemaitre
DOC Various documentation improvements (#21764)
09815e5 
Co-authored-by: Guillaume Lemaitre <g.lemaitre58@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@glemaitre glemaitre glemaitre left review comments

@thomasjpfan thomasjpfan thomasjpfan approved these changes

Assignees
No one assigned
Labels
Documentation module:mixture module:neighbors module:preprocessing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mandjevant @glemaitre @thomasjpfan
0