TST Accelerating ensemble/tests/test_voting.py::test_gridsearch #21422
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ogrisel
reviewed
Oct 23, 2021
| @@ -263,7 +263,7 @@ def test_multilabel(): | |||
| def test_gridsearch(): | |||
| """Check GridSearch support.""" | |||
| clf1 = LogisticRegression(random_state=1) | |||
| clf2 = RandomForestClassifier(random_state=1) | |||
| clf2 = RandomForestClassifier(random_state=1, n_estimators=3) | |||
There was a problem hiding this comment.
If it's still slow, we could set max_depth=3 to make it run even faster.
There was a problem hiding this comment.
If it's still slow, we could set
max_depth=3to make it run even faster.
@ogrisel the test case is not part of the 20 slowest anymore.
We tried max_depth=3 locally, but it didn't result in a visible speedup; not sure why.
There was a problem hiding this comment.
did you measure the time? I think this should be enough and we should merge :)
There was a problem hiding this comment.
Yes we did measure the time (for each test impl we ran the test 3 times); the average running time is reported below:
- original impl: 5.3 seconds
- ogrisel recommended changes: 0.57 seconds
- after adding
max_depth=3: 0.59 seconds
amueller
approved these changes
Oct 23, 2021
ogrisel
approved these changes
Oct 24, 2021
|
and @erodrago! |
24 tasks
ogrisel
pushed a commit
to ogrisel/scikit-learn
that referenced
this pull request
Oct 28, 2021
samronsin
pushed a commit
to samronsin/scikit-learn
that referenced
this pull request
Nov 30, 2021
glemaitre
pushed a commit
to glemaitre/scikit-learn
that referenced
this pull request
Dec 24, 2021
glemaitre
pushed a commit
that referenced
this pull request
Dec 25, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
2B82
Reference Issues/PRs
Towards #21407
What does this implement/fix? Explain your changes.
These changes are accelerating test case
ensemble/tests/test_voting.py::test_gridsearchAny other comments?
Programming partner: @erodrago
#DataUmbrella Sprint