10000 DOC: use notebook-style for plot_svm_regression.py example by jayasuryajsk · Pull Request #22534 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

DOC: use notebook-style for plot_svm_regression.py example #22534

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 19, 2022
Merged

DOC: use notebook-style for plot_svm_regression.py example #22534

merged 4 commits into from
Feb 19, 2022

Conversation

jayasuryajsk
Copy link
Contributor
@jayasuryajsk jayasuryajsk commented Feb 18, 2022 •
edited by lesteve
Loading

Fixed the html rendering issue on the website for this example as per the instructions given.

Part of #22406

@jayasuryajsk jayasuryajsk reopened this Feb 18, 2022
lesteve
lesteve reviewed Feb 18, 2022
View reviewed changes
Copy link
Member
@lesteve lesteve left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make the comments into titles by using --- (of the right length)? I made a suggestion for the first one if you can handle the others in a similar way this would be great!

examples/svm/plot_svm_regression.py
@@ -11,22 +11,22 @@
from sklearn.svm import SVR
import matplotlib.pyplot as plt

# #############################################################################
# %%
# Generate sample data
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Generate sample data
# Generate sample data
# --------------------

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No worries. Done.

@lesteve lesteve mentioned this pull request Feb 19, 2022
Closed
@lesteve lesteve reopened this Feb 19, 2022
@lesteve
Copy link
Member
lesteve commented Feb 19, 2022

I reopened this PR and pushed some tweaks.

Pieces of advice:

@jayasuryajsk
Copy link
Contributor Author

I reopened this PR and pushed some tweaks.

Pieces of advice:

Thank you so much for the advice. I'm new to open source contribution and this is my first project. I'll keep these things in mind for next time.

@lesteve
Copy link
Member
lesteve commented Feb 19, 2022

Merging, thanks a lot!

@lesteve lesteve changed the title Updated the plot_svm_regression.py file DOC: use notebook-style for plot_svm_regression.py example Feb 19, 2022
@lesteve lesteve merged commit 6016083 into scikit-learn:main Feb 19, 2022
@lesteve lesteve mentioned this pull request Feb 21, 2022
Closed
47 tasks
@cmarmo cmarmo mentioned this pull request Feb 26, 2022
Closed
thomasjpfan pushed a commit to thomasjpfan/scikit-learn that referenced this pull request Mar 1, 2022
@jayasuryajsk @lesteve @thomasjpfan
DOC: use notebook-style for plot_svm_regression.py example (scikit-le…
23a09e9 
…arn#22534)

Co-authored-by: Loïc Estève <loic.esteve@ymail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lesteve lesteve lesteve left review comments

Assignees
No one assigned
Labels
Documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jayasuryajsk @lesteve
0