8000 DOC Correct wrong default value in check_scalar docstring · Pull Request #22032 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

DOC Correct wrong default value in check_scalar docstring #22032

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Dec 21, 2021
Merged

DOC Correct wrong default value in check_scalar docstring #22032

merged 1 commit into from Dec 21, 2021

Conversation

ghost
Copy link
@ghost ghost commented Dec 20, 2021

@thomasjpfan thomasjpfan changed the title Changed docstring to correct mistake in html docs DOC Changed docstring to correct mistake in html docs Dec 20, 2021
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for the PR @sveneschlbeck !

LGTM

@lesteve lesteve changed the title DOC Changed docstring to correct mistake in html docs DOC Correct wrong default value in check_scalar docstring Dec 21, 2021
@lesteve lesteve merged commit fa73843 into scikit-learn:main Dec 21, 2021
@lesteve
Copy link
Member
lesteve commented Dec 21, 2021

Merging, thanks a lot!

@ghost ghost deleted the fix_doc branch December 21, 2021 10:38
glemaitre pushed a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
venkyyuvy pushed a commit to venkyyuvy/scikit-learn that referenced this pull request Jan 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

In check_scalar function, max_val default value should be None
2 participants
0