8000 FIX correctly initialize precisions_cholesky_ in GaussianMixture by glemaitre · Pull Request #22058 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

FIX correctly initialize precisions_cholesky_ in GaussianMixture #22058

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Dec 22, 2021
Merged

FIX correctly initialize precisions_cholesky_ in GaussianMixture #22058

merged 5 commits into from
Dec 22, 2021

Conversation

glemaitre
Copy link
Member

closes #16944

Properly initialize precisions_cholesky_ by taking the square root of precisions_init.

thomasjpfan
thomasjpfan approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member
@thomasjpfan thomasjpfan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, otherwise LGTM

lorentzenchr
lorentzenchr approved these changes Dec 22, 2021
View reviewed changes
Copy link
Member
@lorentzenchr lorentzenchr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @glemaitre Thanks for fixing this.

@glemaitre @lorentzenchr
Update doc/whats_new/v1.1.rst
639e592 
Co-authored-by: Christian Lorentzen <lorentzen.ch@gmail.com>
@lorentzenchr lorentzenchr changed the title FIX initialize correctly precisions_cholesky_ in GaussianMixture FIX correctly initialize precisions_cholesky_ in GaussianMixture Dec 22, 2021
@lorentzenchr lorentzenchr merged commit 3e460e8 into scikit-learn:main Dec 22, 2021
glemaitre added a commit to glemaitre/scikit-learn that referenced this pull request Dec 24, 2021
@glemaitre
FIX correctly initialize precisions_cholesky_ in GaussianMixture (sci…
a1538fe 
…kit-learn#22058)
glemaitre added a commit that referenced this pull request Dec 25, 2021
@glemaitre
FIX correctly initialize precisions_cholesky_ in GaussianMixture (#22058
72d483d 
)
venkyyuvy pushed a commit to venkyyuvy/scikit-learn that referenced this pull request Jan 1, 2022
@glemaitre @venkyyuvy
FIX correctly initialize precisions_cholesky_ in GaussianMixture (sci…
3654ea6 
…kit-learn#22058)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@thomasjpfan thomasjpfan thomasjpfan approved these changes

@lorentzenchr lorentzenchr lorentzenchr approved these changes

Assignees
No one assigned
Labels
module:mixture
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

incorrect initialization for self.precisions_cholesky_ in case of diag GaussianMixture
3 participants
@glemaitre @thomasjpfan @lorentzenchr
0