8000 Python 2 code clean up tracker · Issue #15306 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

Python 2 code clean up tracker #15306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
sethtroisi opened this issue Jan 10, 2020 · 10 comments
Closed

Python 2 code clean up tracker #15306

sethtroisi opened this issue Jan 10, 2020 · 10 comments
Labels
03 - Maintenance

Comments

@sethtroisi
Copy link
Contributor

This is a tracker bug for my work on Python2 code cleanup.

I'm creating it to both track my PRs and to allow me to add TODO[gh-####] for future work I want to do but have broken out.
@sethtroisi
Copy link
Contributor Author

Work so far
C code
#15232 #15231
#15304
#15233

Removing python2 only APIs
#15239 #15263 #15268 #15272

@sethtroisi sethtroisi mentioned this issue Jan 10, 2020
Merged
@Zac-HD
Copy link
Contributor
Zac-HD commented Jan 10, 2020

@sethtroisi - have you seen pyupgrade? I've loved it for a while, but it was invaluable when removing Py2 compat from the Hypothesis codebase 😄

@sethtroisi
Copy link
Contributor Author

@Zac-HD I have not, I took a look at their README and I'm not sure if it's going to work the way that numpy has done their PY2->PY3 changes but I'll defiantly give it a try.

@eric-wieser
Copy link
Member
eric-wieser commented Jan 11, 2020 •
edited
Loading

Some postponed work: https://github.com/numpy/numpy/pull/15307/files#r365453208

This was referenced Jan 15, 2020
Merged
Merged
@sethtroisi
Copy link
Contributor Author

https://github.com/numpy/numpy/blob/master/numpy/lib/npyio.py#L421

@mattip
Copy link
Member
mattip commented Jan 19, 2020

xref gh-15352, although not directly connected to this cleanup

@sethtroisi
Copy link
Contributor Author
sethtroisi commented Jan 21, 2020 •
edited
Loading

I thought I had left some str("...") in one of my PR which was to be replaced with "..."
grep -ri '\bstr(".*")' shows only one intentional result, so this is good right now. I also checked for str(b"...")

I found 5 more instances looking for str('.*') but not enough to warrant a cleanup IMHO

@sethtroisi
Copy link
Contributor Author

#15377

This was referenced Jan 23, 2020
Merged
Closed
Closed
Merged
@sethtroisi
Copy link
Contributor Author

I promised to try and upstream some of the changes I've made to tools/refguide_check.py to scipy.
especially those in #15449, #15417, and #15430

@sethtroisi sethtroisi mentioned this issue Jan 29, 2020
Merged
@hugovk hugovk mentioned this issue Sep 3, 2020
Merged
@mattip
Copy link
Member
mattip commented Dec 2, 2020

I think this is finished, so closing. Please reopen or open a new issue if there is still more 2.7 cleanup to be done.

@mattip mattip closed this as completed Dec 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@eric-wieser @mattip @sethtroisi @Zac-HD
0