8000 MAINT: Remove Python2 newbuffer getbuffer by sethtroisi · Pull Request #15239 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Remove Python2 newbuffer getbuffer #15239

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 6, 2020
Merged

MAINT: Remove Python2 newbuffer getbuffer #15239

merged 1 commit into from
Jan 6, 2020

Conversation

sethtroisi
Copy link
Contributor

More Py3K work

@WarrenWeckesser WarrenWeckesser added this to the 1.19.0 release milestone Jan 5, 2020
@WarrenWeckesser
Copy link
Member

Looks good, thanks.

Can you fix the commit message to conform to guidelines?

@WarrenWeckesser
Copy link
Member

It might be better to not change the file doc/Py3K.rst.txt, as that looks like documentation of the 2->3 transition process. I don't think it is intended to be the place to track the current status of what still needs to be done.

@charris
Copy link
Member
charris commented Jan 5, 2020

It might be better to not change the file doc/Py3K.rst.txt

Agree. It is a historical document.

@sethtroisi
Copy link
Contributor Author

ACK on not changing Py3K.rst.txt

@mattip mattip merged commit 7f6ab37 into numpy:master Jan 6, 2020
@mattip
Copy link
Member
mattip commented Jan 6, 2020

Thanks @sethtroisi

@sethtroisi sethtroisi deleted the python3_buffer branch January 6, 2020 17:08
@sethtroisi sethtroisi mentioned this pull request Jan 10, 2020
Closed
@eric-wieser eric-wieser mentioned this pull request Mar 8, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
03 - Maintenance component: numpy._core
Projects
None yet
Milestone
1.19.0 release
Development

Successfully merging this pull request may close these issues.
4 participants
@sethtroisi @WarrenWeckesser @charris @mattip
0