8000 MAINT: cleanup sys.version dependant code by sethtroisi · Pull Request #15307 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: cleanup sys.version dependant code #15307

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 15, 2020
Merged

MAINT: cleanup sys.version dependant code #15307

merged 1 commit into from
Jan 15, 2020

Conversation

sethtroisi
Copy link
Contributor

Prework for #15305

sethtroisi
sethtroisi commented Jan 10, 2020
View reviewed changes
@sethtroisi
Copy link
Contributor Author

Part of #15306

@sethtroisi sethtroisi mentioned this pull request Jan 10, 2020
Merged
eric-wieser
eric-wieser reviewed Jan 10, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed Jan 10, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed Jan 10, 2020
View reviewed changes
eric-wieser
eric-wieser requested changes Jan 10, 2020
View reviewed changes
Copy link
Member
@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly a great, just a few comments to solve first, and some more cleanup ideas

@sethtroisi sethtroisi force-pushed the sys_version_pre branch 2 times, most recently from 05f18ea to 0b16a5f Compare January 11, 2020 01:52
eric-wieser
eric-wieser reviewed Jan 11, 2020
View reviewed changes
eric-wieser
eric-wieser reviewed Jan 11, 2020
View reviewed changes
@sethtroisi sethtroisi force-pushed the sys_version_pre branch 4 times, most recently from 2f5bcc8 to ed25f50 Compare January 13, 2020 04:26
8000
eric-wieser
eric-wieser reviewed Jan 15, 2020
View reviewed changes
numpy/core/tests/test_multiarray.py
assert_raises(ValueError, b[fn3].__setitem__, fnn, 1)
assert_raises(ValueError, b[fn3].__getitem__, fnn)
# multiple subfields
fn2 = str('f2')
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
fn2 = str('f2')
fn2 = 'f2'

Same for the ones up to line 5288.

eric-wieser
eric-wieser approved these changes Jan 15, 2020
View reviewed changes
Copy link
Member
@eric-wieser eric-wieser left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Maybe we should fixup str("...") in a new patch

@mattip mattip merged commit b6bc094 into numpy:master Jan 15, 2020
@mattip
Copy link
Member
mattip commented Jan 15, 2020

Thanks @sethtroisi

@sethtroisi sethtroisi deleted the sys_version_pre branch January 15, 2020 19:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@seberg seberg seberg left review comments

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sethtroisi @mattip @seberg @eric-wieser
0