-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
MAINT: cleanup sys.version dependant code #15307
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Part of #15306 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Mostly a great, just a few comments to solve first, and some more cleanup ideas
05f18ea
to
0b16a5f
Compare
2f5bcc8
to
ed25f50
Compare
ed25f50
to
addf86b
Compare
assert_raises(ValueError, b[fn3].__setitem__, fnn, 1) | ||
assert_raises(ValueError, b[fn3].__getitem__, fnn) | ||
# multiple subfields | ||
fn2 = str('f2') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fn2 = str('f2') | |
fn2 = 'f2' |
Same for the ones up to line 5288.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Maybe we should fixup str("...")
in a new patch
Thanks @sethtroisi |
Prework for #15305