MAINT: cleanup sys.version dependant code #15307
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sethtroisi
commented
Jan 10, 2020
|
Part of #15306 |
eric-wieser
reviewed
Jan 10, 2020
eric-wieser
reviewed
Jan 10, 2020
eric-wieser
reviewed
Jan 10, 2020
eric-wieser
requested changes
Jan 10, 2020
05f18ea to
0b16a5f
Compare
eric-wieser
reviewed
Jan 11, 2020
eric-wieser
reviewed
Jan 11, 2020
2f5bcc8 to
ed25f50
Compare
ed25f50 to
addf86b
Compare
eric-wieser
reviewed
Jan 15, 2020
| assert_raises(ValueError, b[fn3].__setitem__, fnn, 1) | ||
| assert_raises(ValueError, b[fn3].__getitem__, fnn) | ||
| # multiple subfields | ||
| fn2 = str('f2') |
There was a problem hiding this comment.
Suggested change
| fn2 = str('f2') | |
| fn2 = 'f2' |
Same for the ones up to line 5288.
eric-wieser
approved these changes
Jan 15, 2020
|
Thanks @sethtroisi |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prework for #15305