MAINT: Remove Python2 specific C module setup [part2] #15231
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eric-wieser
reviewed
Jan 3, 2020
| @@ -211,7 +205,7 @@ | |||
| \tPy_TYPE(&PyFortran_Type) = &PyType_Type; | |||
| \timport_array(); | |||
| \tif (PyErr_Occurred()) | |||
| \t\t{PyErr_SetString(PyExc_ImportError, \"can't initialize module #modulename# (failed to import numpy)\"); return RETVAL;} | |||
There was a problem hiding this comment.
This looks like it should be return NULL, but let's leave that to a follow-up
There was a problem hiding this comment.
this pattern repeats in a number of places I have a draft pull to try something new..
|
LGTM as well, I would be for simply squash merging this one and closing the previous one here. |
|
CI failure looks unrelated |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some more python2 cleanups building on #14590