8000 STY: absolute vs. relative imports · Issue #15352 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

STY: absolute vs. relative imports #15352

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
mattip opened this issue Jan 19, 2020 · 2 comments
Closed

STY: absolute vs. relative imports #15352

mattip opened this issue Jan 19, 2020 · 2 comments
Labels
03 - Maintenance

Comments

@mattip
Copy link
Member
mattip commented Jan 19, 2020

Many imports in the code are absolute: from numpy.something import something-else. We should convert them to relative imports: from .something import something-else.
@mattip mattip mentioned this issue Jan 19, 2020
Closed
@sethtroisi
Copy link
Contributor

I'm happy to try a pass at this.

@sethtroisi sethtroisi mentioned this issue Jan 20, 2020
Closed
@mattip
Copy link
Member Author
mattip commented Jan 23, 2020

Closing. After seeing the result, I think we should limit the code churn simply to change relative/absolute imports. Both styles are commonly used.

@mattip mattip closed this as completed Jan 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@mattip @sethtroisi
0