MAINT: Cleanup references to python2 #15417
Conversation
0fca1cf to
512f1fa
Compare
| @@ -5,9 +5,6 @@ | |||
| */ | |||
| 8000 #include "typeinfo.h" | |||
|
|
|||
| /* In python 2, this is not exported from Python.h */ | |||
| #include <structseq.h> | |||
There was a problem hiding this comment.
for PyPy3 numpy/core/src/multiarray/typeinfo.c:16:8: error: unknown type name ‘PyStructSequence_Field’
I'll investigate further.
There was a problem hiding this comment.
I reverted removing the include because it fails in PyPy.
I opened an issue on pypy to see if this should be fixed in the future but even if it does that won't be fixed for months.
https://bitbucket.org/pypy/pypy/issues/3160/structseqh-missing-from-pythonh
There was a problem hiding this comment.
Probably better "In PyPy <= 7.3.0", and you can drop the comment if you do
#if (defined(PYPY_VERSION_NUM) && (PYPY_VERSION_NUM <= 0x07030000))
/* PyPy issue 3160 */
#include <structseq.h>
#endif
There was a problem hiding this comment.
Comment updated.
Thanks for the informative comments in the PyPy issue (https://bitbucket.org/pypy/pypy/issues/3160/structseqh-missing-from-pythonh)
512f1fa to
4090d42
Compare
4090d42 to
b6ec168
Compare
b6ec168 to
9ef5f37
Compare
|
Thanks @sethtroisi |
These were found with
grep [pP]ython\s*2and should probably be cleaned up.