8000 MAINT: Remove python2 array_{get,set}slice by sethtroisi · Pull Request #15263 · numpy/numpy · GitHub
[go: up one dir, main page]
Skip to content

MAINT: Remove python2 array_{get,set}slice #15263

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 7, 2020
Merged

MAINT: Remove python2 array_{get,set}slice #15263

merged 1 commit into from
Jan 7, 2020

Conversation

sethtroisi
Copy link
Contributor
@sethtroisi sethtroisi commented Jan 6, 2020 •
edited by eric-wieser
Loading

More Py3K work.

I don't think it needs a release doc but I prepared this version (cribbing from gh-15229) if people want.

Removed ``ndarray.__getslice__`` and ``ndarray.__setslice__``
-------------------------------------------------------------

As part of the continued removal of Python 2 compatibility,
``ndarray.__[gs]etslice__`` was removed. They are already deprecated at a 
language level in python 2.7.

@eric-wieser
Copy link
Member

Tried this back in gh-8592, but we had to revert - clearly safe to do it now though :)

@eric-wieser
Copy link
Member

No need for a release note, the change is unobservable in Python 3

@eric-wieser eric-wieser merged commit ebd2def into numpy:master Jan 7, 2020
@sethtroisi sethtroisi deleted the python3_slicing branch January 7, 2020 18:47
@sethtroisi sethtroisi mentioned this pull request Jan 10, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eric-wieser eric-wieser eric-wieser approved these changes

Assignees
No one assigned
Labels
03 - Maintenance
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@sethtroisi @eric-wieser
0