MAINT: Remove old PY_VERSION_HEX and sys.version_info code #17235
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Let's wait on this a bit, we still support 3.6 in NumPy 1.19 and keeping it for 1.20 is still under discussion. |
|
This keeps 3.6, and only removes stuff for 3.5 and lower. |
eric-wieser
reviewed
Sep 3, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Remove old code wrapped in
PY_VERSION_HEXandsys.version_infochecks for no longer supported Python versions (<3.6).I didn't touch any compat files, as they may still be used by downstream libraries.
Helps #15306.