8000 MAINT: Remove old PY_VERSION_HEX and sys.version_info code by hugovk · Pull Request #17235 · numpy/numpy · GitHub
[go: up one dir, main page]

Skip to content

MAINT: Remove old PY_VERSION_HEX and sys.version_info code #17235

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 7, 2020

Conversation

hugovk
Copy link
Contributor
@hugovk hugovk commented Sep 3, 2020

Remove old code wrapped in PY_VERSION_HEX and sys.version_info checks for no longer supported Python versions (<3.6).

I didn't touch any compat files, as they may still be used by downstream libraries.

Helps #15306.

@charris
Copy link
Member
charris commented Sep 3, 2020

Let's wait on this a bit, we still support 3.6 in NumPy 1.19 and keeping it for 1.20 is still under discussion.

@hugovk
Copy link
Contributor Author
hugovk commented Sep 3, 2020

This keeps 3.6, and only removes stuff for 3.5 and lower.

@charris charris merged commit 32d6157 into numpy:master Sep 7, 2020
@charris
Copy link
Member
charris commented Sep 7, 2020

Thanks @hugovk . @BvB93 Take note, this may affect #17188.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0