8000 Fix scripts so they can work with python3 by ObiWahn · Pull Request #10276 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Fix scripts so they can work with python3 #10276

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom 10000
Merged
merged 7 commits into from
Nov 18, 2019
Merged

Fix scripts so they can work with python3 #10276

merged 7 commits into from
Nov 18, 2019

Conversation

ObiWahn
Copy link
Contributor
@ObiWahn ObiWahn commented Oct 17, 2019

No description provided.

@ObiWahn ObiWahn changed the base branch from devel to feature/upgrade-v8 October 17, 2019 18:23
@ObiWahn ObiWahn changed the base branch from feature/upgrade-v8 to devel October 17, 2019 18:24
@ObiWahn ObiWahn mentioned this pull request Oct 17, 2019
Closed
dothebart
dothebart approved these changes Oct 18, 2019
View reviewed changes
Copy link
Contributor
@dothebart dothebart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please check whether error messages need to have a linebreak - afair one of the differences going from print "bla" to `print("bla")

@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
60cef15 
…ture/switch-some-scripts-to-python3

* 'devel' of https://github.com/arangodb/arangodb: (26 commits)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
  make ccache optional (#10310)
  abort write transactions (#10248)
  url-encode and -decode in place (#10301)
  updated CHANGELOG
  upgrade boost to version 1.71.0 (#10299)
  Feature/explain spliced subqueries (#10298)
  Revert "Feature/react webpack testing (#8712)"
  Feature/react webpack testing (#8712)
  Bug fix/make result ctor noexcept (#10293)
  micro optimizations for case conversion (#10291)
  fix error message (#10281)
  Add Linux to -Werr (#10294)
  make sure error files get built when arangod is built (#10284)
  reactivate warnings as errors (#10286)
  remove extra JSON parser (#10282)
  don't show "NaN" in web interface for cluster RAM usage (#10283)
  Bug fix/some future massaging (#10285)
  ...
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 25, 2019

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6886/

@jsteemann
Copy link
Contributor

Jenkins build failed with Python error:

  File "./utils/generateErrorfile.py", line 124
    print("usage: {} <sourcefile> <outfile>".format(sys.argv[0]), file=sys.stderr)
                                          File "  ./utils/generateExitCodesFiles.py ", line  172 
      print("usage: %s <sourcefile> <outfile>".format(sys.argv[0]), file=sys.stderr)
                                                 ^
 SyntaxError :  invalid syntax 
                                        ^
SyntaxError: invalid syntax

http://172.16.10.101:8080/job/arangodb-matrix-pr-linux/8594/EDITION=community,STORAGE_ENGINE=mmfiles,TEST_SUITE=single,limit=(linux&&test)%7C%7Cgce/artifact/buildArangoDB.log

@Simran-B
Copy link
Contributor
Simran-B commented Oct 25, 2019 •
edited
Loading

What is the %s doing in there?

print("usage: %s <sourcefile> <outfile>".format(sys.argv[0]), file=sys.stderr)

It should be

print("usage: {} <sourcefile> <outfile>".format(sys.argv[0]), file=sys.stderr)

In Python 2, , file=sys.stderr is a syntax error unless the compatibility module is imported at the very beginning of the file:

from __future__ import print_function

https://python-future.org/compatible_idioms.html

@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 25, 2019 •
edited
Loading

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6900/

@ObiWahn ObiWahn self-assigned this Oct 25, 2019
Simran-B
Simran-B reviewed Oct 25, 2019
View reviewed changes
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Oct 25, 2019 •
edited
Loading

http://jenkins01.arangodb.biz:8080/view/PR/job/arangodb-matrix-pr/6907/ - Thank You @Simran-B

blue except for arangodb-matrix-pr-linux-nonmaintainercompile

@ObiWahn
t push Merge branch 'devel' of https://github.com/arangodb/arangodb i…
cccdee1 
…nto feature/switch-some-scripts-to-python3

* 'devel' of https://github.com/arangodb/arangodb: (107 commits)
  fix description of NetworkFeature options
  Bug fix/dont use indexes in progress (#10432)
  rename `lib_libarango_shell` to `libarango_shell`. (#10433)
  fix issues found by cppcheck (#10434)
  Remove IndexHandle (#10424)
  fix invalid assertion (#10429)
  no coordinators left behind (#10422)
  fix compile warning in AnalyzerFeature test
  allow using `RANDOM_TOKEN` AQL function with an argument value of `0`. (#10414)
  centralize cloning functionality for AstNodes (#10430)
  Don't modify a finalized node. (#10419)
  Bug fix/internal issue #651 (#10415)
  show index type in not implemented exception (#10426)
  Parallel SortingGatherExecutor (#10410)
  "run with --log v8=debug" to see the stacktraces of logged error messages (#10373)
  ARANGODB_UPGRADE_DURING_RESTORE env variable. (#10385)
  add optional exclusive writes to rocksdb engine (#10364)
  attempt to make test more deterministic
  Feature/parallel aql phase one 2 (#10408)
  Improve syncer error message (#10403)
  ...
@ObiWahn
Copy link
Contributor Author
ObiWahn commented Nov 14, 2019

https://172.16.10.101/view/PR/job/arangodb-matrix-pr/7189/

@jsteemann jsteemann merged commit f58c1f8 into devel Nov 18, 2019
@jsteemann jsteemann deleted the feature/switch-some-scripts-to-python3 branch November 18, 2019 09:33
ObiWahn added a commit that referenced this pull request Nov 18, 2019
@ObiWahn
Merge branch 'devel' of https://github.com/arangodb/arangodb into fea…
22a7bfc 
…ture/dump-db-properties

* 'devel' of https://github.com/arangodb/arangodb:
  Fix scripts so they can work with python3 (#10276)
  Backup with view (#10386)
  Bug fix/fix late materialization used after sort (#10447)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Simran-B Simran-B Simran-B left review comments

@dothebart dothebart dothebart approved these changes

@jsteemann jsteemann Awaiting requested review from jsteemann

Assignees

@ObiWahn ObiWahn

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@ObiWahn @jsteemann @Simran-B @dothebart
0