start upgrading V8 to 7.7.299 #10274
Conversation
|
@cclauss @refack for the errors obvious to me I've provided pull requests, it would be good if you could lend me a helping hand on identifying my currently remaining issue which doesn't error out, but simply produces errnous behaviour: I'm using the nodejs gypfiles, and invoke gyp like this: which will run through, however it seems that some files are missing partially; If I get that correctly there is a module loading source file lists from .gni files, right? The node-gyp generated makefiles contain dependencies to Any hints? |
|
Ok, V8_ROOT has to be relative, if its absolute, everything breaks. |
|
#10276 get this as soon as it lands in devel. |
ImportError: bad magic number in 'gyp': b'\x03\xf3\r\n' Can be fixed by running |
|
Related to arangodb#10278 and the request for assistance at arangodb#10274 (comment) ``` 1 E902 TokenError: EOF in multi-line statement 181 E999 SyntaxError: invalid syntax 6 F632 use ==/!= to compare str, bytes, and int literals 11 F633 use of >> is invalid with print function 2 F723 syntax error in type comment 'Dict[option, Dict[col_fam, value]] X 2 ->' 121 F821 undefined name 'execfile' 322 ```
|
@dothebart do you know which gyp is loaded and if the version matches? I had no luck with |
Does the directive |
|
at least for me gyp now does what its expected to - fighting torque now. |
…godb into feature/upgrade-v8 * 'feature/upgrade-v8' of https://github.com/arangodb/arangodb: add symlink remove non-linked
…o feature/upgrade-v8
lib/V8/v8-globals.h
Outdated
| @@ -756,7 +760,7 @@ TRI_v8_global_t* TRI_GetV8Globals(v8::Isolate*); | |||
| template <typename TARGET> | |||
| bool TRI_V8_AddProtoMethod(v8::Isolate* isolate, TARGET tpl, v8::Handle<v8::String> name, | |||
| v8::FunctionCallback callback, bool isHidden = false) { | |||
| // hidden method | |||
| /* // hidden method | |||
There was a problem hiding this comment.
-771,7 +771,7 @@ bool TRI_V8_AddProtoMethod(v8::Isolate* isolate, TARGET tpl, v8::Handle<v8::Stri
/// @brief adds a method to an object
template <typename TARGET>
-inline bool TRI_V8_AddMethod(v8::Isolate* isolate, TARGET tpl, v8::Handle<v8::String> name,
+inline bool TRI_V8_AddMethod(v8::Isolate* isolate, v8::MaybeLocal<TARGET> tpl, v8::Handle<v8::String> name,
v8::Handle<v8::FunctionTemplate> callback,
bool isHidden = false) {
// hidden method
@@ -787,8 +787,9 @@ inline bool TRI_V8_AddMethod(v8::Isolate* isolate, TARGET tpl, v8::Handle<v8::St
}
template <typename TARGET>
-inline bool TRI_V8_AddMethod(v8::Isolate* isolate, TARGET tpl, v8::Handle<v8::String> name,
+inline bool TRI_V8_AddMethod(v8::Isolate* isolate, v8::MaybeLocal<TARGET> tpl, v8::Handle<v8::String> name,
v8::FunctionCallback callback, bool isHidden = false) {
+
maybe we should do this instead
|
Can you split the PR. It becomes impossible do to good review here.
|
|
Superseeded by #10978 - which will directly go to the currently available V8 version. |
Starting to deploy the new V8