-
Notifications
You must be signed in to change notification settings - Fork 853
Feature/react webpack testing #8712
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s a total refactor
…re/react-webpack-testing
…re/react-webpack-testing
…ild to git ignore.
…rangodb into feature/react-webpack-testing
pluma
reviewed
Oct 14, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but some clarifications.
js/apps/system/_admin/aardvark/APP/frontend/js/collections/arangoUsers.js
Outdated
Show resolved
Hide resolved
js/apps/system/_admin/aardvark/APP/frontend/js/views/clusterView.js
Outdated
Show resolved
Hide resolved
js/apps/system/_admin/aardvark/APP/frontend/js/views/footerView.js
Outdated
Show resolved
Hide resolved
js/apps/system/_admin/aardvark/APP/frontend/js/views/queryView.js
Outdated
Show resolved
Hide resolved
…ct-webpack-testing
@mchacki now finally mergeable :) |
…ct-webpack-testing
mchacki
approved these changes
Oct 22, 2019
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
ObiWahn
added a commit
that referenced
this pull request
Oct 23, 2019
…ture/upgrade-v8 * 'devel' of https://github.com/arangodb/arangodb: updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294)
ObiWahn
added a commit
that referenced
this pull request
Oct 23, 2019
…ture/smart-join-views-2 * 'devel' of https://github.com/arangodb/arangodb: (24 commits) url-encode and -decode in place (#10301) updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294) make sure error files get built when arangod is built (#10284) reactivate warnings as errors (#10286) remove extra JSON parser (#10282) don't show "NaN" in web interface for cluster RAM usage (#10283) Bug fix/some future massaging (#10285) pacify Valgrind on shutdown use C++17 [[fallthrough]] (#10280) Remove accidentally committed file Try to use gcc 9.2.0 (#10277) Revert "Try to use gcc 9.2.0" ...
ObiWahn
added a commit
that referenced
this pull request
Oct 24, 2019
…ture/cpp17-clean-up * 'devel' of https://github.com/arangodb/arangodb: make ccache optional (#10310) abort write transactions (#10248) url-encode and -decode in place (#10301) updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294) make sure error files get built when arangod is built (#10284)
ObiWahn
added a commit
that referenced
this pull request
Oct 25, 2019
…ture/switch-some-scripts-to-python3 * 'devel' of https://github.com/arangodb/arangodb: (26 commits) upgrade vpack library (#10314) avoid string copies in several cases (#10317) Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312) make ccache optional (#10310) abort write transactions (#10248) url-encode and -decode in place (#10301) updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294) make sure error files get built when arangod is built (#10284) reactivate warnings as errors (#10286) remove extra JSON parser (#10282) don't show "NaN" in web interface for cluster RAM usage (#10283) Bug fix/some future massaging (#10285) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pluma Just for better readability