make sure error files get built when arangod is built #10284
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
goedderz
requested changes
Oct 21, 2019
arangod/CMakeLists.txt
Outdated
| if (USE_MAINTAINER_MODE) | ||
| add_dependencies(arangod errorfiles) | ||
| add_dependencies(arangod exitcodefiles) | ||
| endif () |
There was a problem hiding this comment.
While the error- and exitcodefiles are built now, they might be built after arango is built, which contains them. So I think it'd be better to move this to lib/CMakeLists.txt and as a dependency to arango, not arangod.
…uild-errorfiles-when-building-arangod
goedderz
approved these changes
Oct 21, 2019
| @@ -961,7 +961,7 @@ endif () | |||
| if (USE_JEMALLOC) | |||
| add_dependencies(arangod jemalloc) | |||
| endif () | |||
|
|
|||
ObiWahn
added a commit
that referenced
this pull request
Oct 23, 2019
…ture/smart-join-views-2 * 'devel' of https://github.com/arangodb/arangodb: (24 commits) url-encode and -decode in place (#10301) updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294) make sure error files get built when arangod is built (#10284) reactivate warnings as errors (#10286) remove extra JSON parser (#10282) don't show "NaN" in web interface for cluster RAM usage (#10283) Bug fix/some future massaging (#10285) pacify Valgrind on shutdown use C++17 [[fallthrough]] (#10280) Remove accidentally committed file Try to use gcc 9.2.0 (#10277) Revert "Try to use gcc 9.2.0" ...
ObiWahn
added a commit
that referenced
this pull request
Oct 24, 2019
…ture/cpp17-clean-up * 'devel' of https://github.com/arangodb/arangodb: make ccache optional (#10310) abort write transactions (#10248) url-encode and -decode in place (#10301) updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294) make sure error files get built when arangod is built (#10284)
ObiWahn
added a commit
that referenced
this pull request
Oct 25, 2019
…ture/switch-some-scripts-to-python3 * 'devel' of https://github.com/arangodb/arangodb: (26 commits) upgrade vpack library (#10314) avoid string copies in several cases (#10317) Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312) make ccache optional (#10310) abort write transactions (#10248) url-encode and -decode in place (#10301) updated CHANGELOG upgrade boost to version 1.71.0 (#10299) Feature/explain spliced subqueries (#10298) Revert "Feature/react webpack testing (#8712)" Feature/react webpack testing (#8712) Bug fix/make result ctor noexcept (#10293) micro optimizations for case conversion (#10291) fix error message (#10281) Add Linux to -Werr (#10294) make sure error files get built when arangod is built (#10284) reactivate warnings as errors (#10286) remove extra JSON parser (#10282) don't show "NaN" in web interface for cluster RAM usage (#10283) Bug fix/some future massaging (#10285) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Scope & Purpose
Add a depedency so error files get (re)built when arangod is built.
Testing & Verification
This change is a trivial rework / code cleanup without any test coverage.
https://172.16.10.101/view/PR/job/arangodb-matrix-pr/6790/