8000 avoid string copies in several cases by jsteemann · Pull Request #10317 · arangodb/arangodb · GitHub
[go: up one dir, main page]

Skip to content

avoid string copies in several cases #10317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 25, 2019
Merged

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Avoid copying strings in several cases

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • The behavior change can be verified via automatic tests

Testing & Verification

This change is a trivial rework / code cleanup without any test coverage.

However, existing tests should pass.

https://jenkins01.arangodb.biz/view/PR/job/arangodb-matrix-pr/6880/

@jsteemann jsteemann added this to the devel milestone Oct 24, 2019
@jsteemann jsteemann requested a review from ObiWahn October 24, 2019 19:04
@jsteemann
Copy link
Contributor Author

Tests blue

Copy link
Contributor
@ObiWahn ObiWahn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jsteemann jsteemann merged commit 46e98d7 into devel Oct 25, 2019
@jsteemann jsteemann deleted the bug-fix/avoid-string-copying branch October 25, 2019 08:47
ObiWahn added a commit that referenced this pull request Oct 25, 2019
…ture/switch-some-scripts-to-python3

* 'devel' of https://github.com/arangodb/arangodb: (26 commits)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
  make ccache optional (#10310)
  abort write transactions (#10248)
  url-encode and -decode in place (#10301)
  updated CHANGELOG
  upgrade boost to version 1.71.0 (#10299)
  Feature/explain spliced subqueries (#10298)
  Revert "Feature/react webpack testing (#8712)"
  Feature/react webpack testing (#8712)
  Bug fix/make result ctor noexcept (#10293)
  micro optimizations for case conversion (#10291)
  fix error message (#10281)
  Add Linux to -Werr (#10294)
  make sure error files get built when arangod is built (#10284)
  reactivate warnings as errors (#10286)
  remove extra JSON parser (#10282)
  don't show "NaN" in web interface for cluster RAM usage (#10283)
  Bug fix/some future massaging (#10285)
  ...
ObiWahn added a commit that referenced this pull request Oct 25, 2019
* origin/devel:
  micro optimizations (#10316)
  test attempt to increase max collection name length from 64 chars to 256 (#9890)
  Feature/force backup (#10265)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
ObiWahn added a commit that referenced this pull request Oct 28, 2019
…ture/smart-join-views-2

* 'devel' of https://github.com/arangodb/arangodb:
  rawPayload shouldn't return the full reply buffer (#10319)
  micro optimizations (#10316)
  test attempt to increase max collection name length from 64 chars to 256 (#9890)
  Feature/force backup (#10265)
  upgrade vpack library (#10314)
  avoid string copies in several cases (#10317)
  Round index estimates when comparing plan, we do not really care for exact equallity, they should only not be off by much (#10312)
  make ccache optional (#10310)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants
0