8000 allow using `RANDOM_TOKEN` AQL function with an argument value of `0`. by jsteemann · Pull Request #10414 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

allow using RANDOM_TOKEN AQL function with an argument value of 0. #10414

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sig 8000 n up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 13, 2019
Merged

allow using RANDOM_TOKEN AQL function with an argument value of 0. #10414

merged 1 commit into from
Nov 13, 2019

Conversation

jsteemann
Copy link
Contributor

Scope & Purpose

Allow usage of RANDOM_TOKEN AQL function with an argument value of 0.
This produces an empty string now, whereas in previous versions of ArangoDB it threw an invalid value exception.

  • Bug-Fix for devel-branch (i.e. no need for backports?)
  • The behavior in this PR can be (and was) manually tested (support / qa / customers can test it)
  • The behavior change can be verified via automatic tests

Testing & Verification

This change is already covered by existing tests, such as shell_server_aql.

https://172.16.10.101/view/PR/job/arangodb-matrix-pr/7141/

@jsteemann jsteemann added this to the devel milestone Nov 13, 2019
@jsteemann jsteemann merged commit fd87abc into devel Nov 13, 2019
@jsteemann jsteemann deleted the bug-fix/allow-random-token-with-length-0 branch November 13, 2019 21:20
lservini
lservini reviewed Nov 14, 2019
View reviewed changes
Copy link
Contributor
@lservini lservini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@lservini lservini mentioned this pull request Nov 14, 2019
Merged
ObiWahn added a commit that referenced this pull request Nov 14, 2019
@ObiWahn
t push Merge branch 'devel' of https://github.com/arangodb/arangodb i…
cccdee1 
…nto feature/switch-some-scripts-to-python3

* 'devel' of https://github.com/arangodb/arangodb: (107 commits)
  fix description of NetworkFeature options
  Bug fix/dont use indexes in progress (#10432)
  rename `lib_libarango_shell` to `libarango_shell`. (#10433)
  fix issues found by cppcheck (#10434)
  Remove IndexHandle (#10424)
  fix invalid assertion (#10429)
  no coordinators left behind (#10422)
  fix compile warning in AnalyzerFeature test
  allow using `RANDOM_TOKEN` AQL function with an argument value of `0`. (#10414)
  centralize cloning functionality for AstNodes (#10430)
  Don't modify a finalized node. (#10419)
  Bug fix/internal issue #651 (#10415)
  show index type in not implemented exception (#10426)
  Parallel SortingGatherExecutor (#10410)
  "run with --log v8=debug" to see the stacktraces of logged error messages (#10373)
  ARANGODB_UPGRADE_DURING_RESTORE env variable. (#10385)
  add optional exclusive writes to rocksdb engine (#10364)
  attempt to make test more deterministic
  Feature/parallel aql phase one 2 (#10408)
  Improve syncer error message (#10403)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lservini lservini lservini left review comments

@dothebart dothebart Awaiting requested review from dothebart

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
devel
Development

Successfully merging this pull request may close these issues.
2 participants
@jsteemann @lservini
0