10000 Allow addEdge() to take vertex ids in the JS library by moonglum · Pull Request #651 · arangodb/arangodb · GitHub
[go: up one dir, main page]
Skip to content

Allow addEdge() to take vertex ids in the JS library #651

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 31, 2013
Merged

Allow addEdge() to take vertex ids in the JS library #651

merged 4 commits into from
Oct 31, 2013

Conversation

moonglum
Copy link

Original Issue: 528

Currently, this works:

v1 = graph.addVertex();
v2 = graph.addVertex();

z = graph.addEdge(v1, v2, null, {"name":"john smith"});

However, sometimes, I have the ID of a vertex, but not a reference to
it. I can of course, ask ArangoDB to retrieve the vertex and then use it
with addEdge(), but that's not efficient.

I would love to be able to do this:

z = graph.addEdge('myvertexcollection/123', 'myvertexcollection/456',
null, {"name":"john smith"});

@moonglum moonglum mentioned this pull request Oct 31, 2013
Closed
moonglum added a commit that referenced this pull request Oct 31, 2013
@moonglum
Merge pull request #651 from triAGENS/add-edge-takes-id
71c0475 
Allow addEdge() to take vertex ids in the JS library
@moonglum moonglum merged commit 71c0475 into devel Oct 31, 2013
@moonglum
Copy link
Author

Also closes #528

@moonglum moonglum deleted the add-edge-takes-id branch October 31, 2013 12:34
KVS85 pushed a commit that referenced this pull request Nov 12, 2019
@gnusi @KVS85
Bug fix 3.5/internal issue #651 (#10388)
3a0ed2f 
* extract recursive part of IResearchLinkMeta

* avoid saving analyzer definition during link meta initialization

* add tests to check cluster deadlock

* cleanup

* code cleanup

* add moar tests

* mooooaaar checks

* make jslint happy

* backport fix for cluster startup from 3.5.2 branch

* backport changes from 3.5.2

* fix tests

* fix tests

* moar fixes

* refactor analyzer definitions tracking

* add some tests

* extend dump tests

* add tests for replication

* fix tests

* more fixes

* address jslint errors

* address review comments

* address test failures

* reflect changes in changelog
gnusi added a commit that referenced this pull request Nov 13, 2019
@gnusi
Bug fix 3.5/internal issue #651 (#10388)
e1e3b74 
* extract recursive part of IResearchLinkMeta

* avoid saving analyzer definition during link meta initialization

* add tests to check cluster deadlock

* cleanup

* code cleanup

* add moar tests

* mooooaaar checks

* make jslint happy

* backport fix for cluster startup from 3.5.2 branch

* backport changes from 3.5.2

* fix tests

* fix tests

* moar fixes

* refactor analyzer definitions tracking

* add some tests

* extend dump tests

* add tests for replication

* fix tests

* more fixes

* address jslint errors

* address review comments

* address test failures

* reflect changes in changelog

# Conflicts:
#	arangod/IResearch/IResearchAnalyzerFeature.cpp
#	arangod/IResearch/IResearchFilterFactory.cpp
#	arangod/IResearch/IResearchLink.cpp
#	arangod/IResearch/IResearchLinkMeta.cpp
#	tests/IResearch/IResearchAnalyzerFeature-test.cpp
#	tests/IResearch/IResearchDocument-test.cpp
#	tests/IResearch/IResearchFilterBoolean-test.cpp
#	tests/IResearch/IResearchFilterCompare-test.cpp
#	tests/IResearch/IResearchFilterFunction-test.cpp
#	tests/IResearch/IResearchFilterIn-test.cpp
#	tests/IResearch/IResearchLinkHelper-test.cpp
#	tests/IResearch/IResearchLinkMeta-test.cpp
#	tests/IResearch/IResearchView-test.cpp
#	tests/V8Server/v8-analyzers-test.cpp
gnusi added a commit that referenced this pull request Nov 13, 2019
@gnusi
Bug fix/internal issue #651 (#10415)
ff93f45 
* Bug fix 3.5/internal issue #651 (#10388)

* extract recursive part of IResearchLinkMeta

* avoid saving analyzer definition during link meta initialization

* add tests to check cluster deadlock

* cleanup

* code cleanup

* add moar tests

* mooooaaar checks

* make jslint happy

* backport fix for cluster startup from 3.5.2 branch

* backport changes from 3.5.2

* fix tests

* fix tests

* moar fixes

* refactor analyzer definitions tracking

* add some tests

* extend dump tests

* add tests for replication

* fix tests

* more fixes

* address jslint errors

* address review comments

* address test failures

* reflect changes in changelog

# Conflicts:
#	arangod/IResearch/IResearchAnalyzerFeature.cpp
#	arangod/IResearch/IResearchFilterFactory.cpp
#	arangod/IResearch/IResearchLink.cpp
#	arangod/IResearch/IResearchLinkMeta.cpp
#	tests/IResearch/IResearchAnalyzerFeature-test.cpp
#	tests/IResearch/IResearchDocument-test.cpp
#	tests/IResearch/IResearchFilterBoolean-test.cpp
#	tests/IResearch/IResearchFilterCompare-test.cpp
#	tests/IResearch/IResearchFilterFunction-test.cpp
#	tests/IResearch/IResearchFilterIn-test.cpp
#	tests/IResearch/IResearchLinkHelper-test.cpp
#	tests/IResearch/IResearchLinkMeta-test.cpp
#	tests/IResearch/IResearchView-test.cpp
#	tests/V8Server/v8-analyzers-test.cpp

* fix tests

* fix tests

* Fix tests

* fix replication tests
ObiWahn added a commit that referenced this pull request Nov 14, 2019
@ObiWahn
t push Merge branch 'devel' of https://github.com/arangodb/arangodb i…
cccdee1 
…nto feature/switch-some-scripts-to-python3

* 'devel' of https://github.com/arangodb/arangodb: (107 commits)
  fix description of NetworkFeature options
  Bug fix/dont use indexes in progress (#10432)
  rename `lib_libarango_shell` to `libarango_shell`. (#10433)
  fix issues found by cppcheck (#10434)
  Remove IndexHandle (#10424)
  fix invalid assertion (#10429)
  no coordinators left behind (#10422)
  fix compile warning in AnalyzerFeature test
  allow using `RANDOM_TOKEN` AQL function with an argument value of `0`. (#10414)
  centralize cloning functionality for AstNodes (#10430)
  Don't modify a finalized node. (#10419)
  Bug fix/internal issue #651 (#10415)
  show index type in not implemented exception (#10426)
  Parallel SortingGatherExecutor (#10410)
  "run with --log v8=debug" to see the stacktraces of logged error messages (#10373)
  ARANGODB_UPGRADE_DURING_RESTORE env variable. (#10385)
  add optional exclusive writes to rocksdb engine (#10364)
  attempt to make test more deterministic
  Feature/parallel aql phase one 2 (#10408)
  Improve syncer error message (#10403)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@moonglum
0