[Form] Fixed ValidatorTypeGuesser to guess unmapped properties not to be required #7203
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I would like to see some progress on this issue. If I can help in something, please, let me know. |
|
ref #7181 |
|
What about this one @bschussek? Can we close it? Do you want to finish it? |
… (lyrixx) This PR was submitted for the 2.5 branch but it was merged into the 2.3 branch instead (closes symfony#11464). Discussion ---------- [Translator] Use quote to surround invalid locale | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - I got this mess 8000 age in one application (CLI): ``` [InvalidArgumentException] Invalid locale: en_US . ``` It's not so easy to spot the issue. Commits ------- c9742ef [Translator] Use quote to surround invalid locale
If null is passed to denormalize(), no property values can be set on the denormalized object. Additionally, this fixes passing values to the denormalized object's constructor if the incoming data is an object.
…cloning a container in the GrahpvizDumper (jakzal) This PR was merged into the 2.3 branch. Discussion ---------- Pass a Scope instance instead of a scope name when cloning a container in the GrahpvizDumper | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11055 | License | MIT | Doc PR | - Commits ------- 6787669 [DependencyInjection] Pass a Scope instance instead of a scope name.
This PR was merged into the 2.3 branch. Discussion ---------- Fix issue described in symfony#11421 | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11421 | License | MIT | Doc PR | NA This pull request fixes the issue described in symfony#11421. It also adds a test for the issue. The issue is present in 2.0 forward, but I decided to fix it on the 2.3 branch so that I could also write a test for it (2.0 had no tests for the Process component, and 2.1 and 2.2 didn't have tests for the `ExecutableFinder` class). Commits ------- 4cf50e8 Bring code into standard 9f4313c [Process] Add test to verify fix for issue symfony#11421 02eb765 [Process] Fixes issue symfony#11421
…sion (bcremer, fabpot) This PR was merged into the 2.3 branch. Discussion ---------- [BrowserKit] Fixed server HTTP_HOST port uri conversion | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11356 | License | MIT | Doc PR | n/a See symfony#11356 Commits ------- 103fd88 [BrowserKit] refactor code and fix unquoted regex f401ab9 Fixed server HTTP_HOST port uri conversion
wait() throws an exception when the process was terminated by a signal. This should not happen when the termination was requested by calling either the stop() or the signal() method (for example, inside a callback which is passed to wait()).
…abbuh, romainneutron) This PR was merged into the 2.3 branch. Discussion ---------- fix signal handling in wait() on calls to stop() | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11286 | License | MIT | Doc PR | ``wait()`` throws an exception when the process was terminated by a signal. This should not happen when the termination was requested by calling the ``stop()`` method (for example, inside a callback which is passed to ``wait()``). Commits ------- 5939d34 [Process] Fix unit tests in sigchild environment eb68662 [Process] fix signal handling in wait() 94ffc4f bug symfony#11469 [BrowserKit] Fixed server HTTP_HOST port uri conversion (bcremer, fabpot) 103fd88 [BrowserKit] refactor code and fix unquoted regex f401ab9 Fixed server HTTP_HOST port uri conversion 045cbc5 bug symfony#11425 Fix issue described in symfony#11421 (Ben, ben-rosio) f5bfa9b bug symfony#11423 Pass a Scope instance instead of a scope name when cloning a container in the GrahpvizDumper (jakzal) 3177be5 minor symfony#11464 [Translator] Use quote to surround invalid locale (lyrixx) c9742ef [Translator] Use quote to surround invalid locale 4dbe0e1 bug symfony#11120 [2.3][Process] Reduce I/O load on Windows platform (romainneutron) 797d814 bug symfony#11342 [2.3][Form] Check if IntlDateFormatter constructor returned a valid object before using it (romainneutron) 0b5348e minor symfony#11441 [Translator] Optimize assertLocale regexp (Jérémy Derussé) 537c39b Optimize assertLocale regexp 4cf50e8 Bring code into standard 9f4313c [Process] Add test to verify fix for issue symfony#11421 02eb765 [Process] Fixes issue symfony#11421 6787669 [DependencyInjection] Pass a Scope instance instead of a scope name. 9572918 bug symfony#11411 [Validator] Backported symfony#11410 to 2.3: Object initializers are called only once per object (webmozart) 291cbf9 [Validator] Backported symfony#11410 to 2.3: Object initializers are called only once per object efab884 bug symfony#11403 [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator (takeit) 3176f8b [Translator][FrameworkBundle] Added @ to the list of allowed chars in Translator 91e32f8 bug symfony#11381 [2.3] [Process] Use correct test for empty string in UnixPipes (whs, romainneutron) 45df2f3 minor symfony#11397 [2.3][Process] Fix unit tests on Windows platform (romainneutron) cec0a45 [Process] Adjust PR symfony#11264, make it Windows compatible and fix CS d418935 [Process] Fix unit tests on Windows platform ff0bb01 [Process] Reduce I/O load on Windows platform ace5a29 bumped Symfony version to 2.3.19 75e07e6 updated VERSION for 2.3.18 4a12f4d update CONTRIBUTORS for 2.3.18 98b891d updated CHANGELOG for 2.3.18 06a80fb Validate locales sets intos translator 06fc97e feature symfony#11367 [HttpFoundation] Fix to prevent magic bytes injection in JSONP responses... (CVE-2014-4671) (Andrew Moore) 3c54659 minor symfony#11387 [2.3] [Validator] Fix UserPassword validator translation (redstar504) 73d50ed Fix UserPassword validator translation 93a970c bug symfony#11386 Remove Spaceless Blocks from Twig Form Templates (chrisguitarguy) 8f9ed3e Remove Spaceless Blocks from Twig Form Templates 9e1ea4a [Process] Use correct test for empty string in UnixPipes 6af3d05 [HttpFoundation] Fix to prevent magic bytes injection in JSONP responses (Prevents CVE-2014-4671) ebf967d [Form] Check if IntlDateFormatter constructor returned a valid object before using it
When event listeners for certain events are removed from the event dispatcher, empty arrays are not being removed. Therefore, counting on empty arrays leads to wrong results of the hasListeners() method.
This PR was merged into the 2.3 branch. Discussion ---------- Unify null comparisons | Q | A | ------------- | --- | Fixed tickets | - | License | MIT Commits ------- be04c50 Unify null comparisons
This PR was merged into the 2.3 branch. Discussion ---------- remove unused imports | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 9cd059e remove unused imports
This PR was merged into the 2.3 branch. Discussion ---------- [EventDispatcher] don't count empty listeners | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#11444 | License | MIT | Doc PR | When event listeners for certain events are removed from the event dispatcher, empty arrays are not being removed. Therefore, counting on empty arrays leads to wrong results of the hasListeners() method. Thanks to @mlindenb for discovering this an proposing a solution. Commits ------- fdbb04a [EventDispatcher] don't count empty listeners
Spelling of 'CSRF' was incorrect
This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#11491). Discussion ---------- Update validators.eu.xlf Spelling of 'CSRF' was incorrect Commits ------- d432395 Update validators.eu.xlf
…e is an array, object or resource This was decided in the discussion of symfony#10687.
…iolations (eagleoneraptor, webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Validator] Fixed string conversion in constraint violations | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#10675 | License | MIT | Doc PR | - Commits ------- 32ae95b [Validator] Added more detailed inline documentation 08ea6d3 [Validator] Removed information from the violation output if the value is an array, object or resource d6a783f [Validator] Renamed valueToString() to formatValue(); added missing formatValue() calls 71897d7 [Validator] Fixed CS cea4155 [Validator] Fixed date-to-string conversion tests to match ICU 51 5aa7e6d [Validator] Added "{{ value }}" parameters where they were missing f329552 [Validator] Simplified and explained the LuhnValidator bff09f2 [Validator] Simplified IssnValidator 224e70f [Validator] Fixed and simplified IsbnValidator fd58870 [Validator] Simplified IBAN validation algorithm 97243bc [Validator] Fixed value-to-string conversion in constraint violations 75e8815 [Validator] Fix constraint violation message parameterization
The underlying data variable is typed as mixed whereas the methods paramers where typed as array.
…satoTremor) This PR was merged into the 2.3 branch. Discussion ---------- [Form] Fix PHPDoc for builder setData methods | Q | A | ------------- | --- | Fixed tickets | symfony#11933 | License | MIT The underlying data variable is typed as mixed whereas the methods paramers where typed as array. The method is also described to accept objects, etc. in the documentation. Commits ------- c207d1d [Form] Fix PHPDoc for builder setData methods The underlying data variable is typed as mixed whereas the methods paramers where typed as array.
…BinaryFileReponse file path (nervo) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#11837). Discussion ---------- Use getPathname() instead of string casting to get BinaryFileReponse file path According to the code, should be "File" instead of "\SplFileInfo" Commits ------- e1eb788 Use getPathname() instead of string casting to get BinaryFileReponse file path
This PR was merged into the 2.3 branch. Discussion ---------- [HttpFoundation] fixed some volatile tests | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | see symfony#11588 | License | MIT | Doc PR | n/a Commits ------- 00c1b75 [Process] fixed some volatile tests 974bf01 [HttpKernel] fixed a volatile test 6020c43 [HttpFoundation] fixed some volatile tests
This PR was squashed before being merged into the 2.3 branch (closes symfony#11970). Discussion ---------- [Finder] Escape location for regex searches | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If the location to start searching in contains a regex special char like + or ? and the path restriction is a regular expresion with a start limitation. No results will be found wtih at least GnuFindAdapter - e.g.: ``` use Symfony\Component\Finder\Finder; use Symfony\Component\Finder\Adapter; mkdir('/tmp/reg+ex/dir/subdir', 0777, true); $finder = Finder::create() ->removeAdapters() ->addAdapter(new Adapter\GnuFindAdapter()); $finder->in('/tmp/reg+ex')->path('/^dir/'); print count($finder)."\n"; ``` Expected result: 2 Actual result is: 0 This pull request consists of: * a new test checking for this bug (0e81086) * the actual fix (6595b6b) * changes to comply with the coding standard (7f199c5) ## How to reproduce ### Fastest way 1. Move or copy your local symfony clone into a location containing special regex chars: * `mv symfony symfony+regex` 2. Run tests in there * `cd symfony+regex && phpunit` > Result: Some tests in the finder component will fail. ### Alternative: A new clone 1. Clone symfony in a directory containing at least one regex special char * `git clone https://github.com/symfony/symfony.git /tmp/symfony+regexchar` 2. As usual get composer, install dependencies and get phpunit * You might simply want to follow [this guide](http://symfony.com/doc/current/contributing/code/tests.html) 3. Run tests in there * `cd /tmp/symfony+regexchar && phpunit` > Result: Some tests in the finder component will fail. ### Alternative: Apply the new test 1. Apply commit a29d120 to your symfony clone 2. Run tests > Result: The new test will fail. Commits ------- b63926b [Finder] Escape location for regex searches
…y() (znerol) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#11981). Discussion ---------- Fix @return docs on HttpCache::restoreResponseBody() Commits ------- 37dc57b Fix @return docs on HttpCache::restoreResponseBody()
… (thewilkybarkid) This PR was merged into the 2.3 branch. Discussion ---------- [HttpKernel] Make sure HttpCache is a trusted proxy | Q | A | ------------- | --- | Bug fix? | yes (of sorts) | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#9292 | License | MIT | Doc PR | symfony/symfony-docs#4239 Fixes symfony#9292 by adding `127.0.0.1` as a trusted proxy when using `HttpCache` (assuming it hasn't been already). Commits ------- ca65362 Make sure HttpCache is a trusted proxy
…nneutron) This PR was squashed before being merged into the 2.3 branch (closes symfony#11340). Discussion ---------- [2.3] Add missing development dependencies | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT I've also added a run of the test suite in every component scope. Commits ------- 3b02af9 [2.3] Add missing development dependencies
…ilesystem issues. A previous commit introduced a folder with a question mark and an asterisk which are invalid NTFS folder name characters and prevented checkout on those systems.
…rsing xliff file (pulzarraider) This PR was merged into the 2.3 branch. Discussion ---------- [Translation] [Config] Clear libxml errors after parsing xliff file | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | - | License | MIT | Doc PR | - If libxml_use_internal_errors is set to `true` before parsing xliff file, the libxml errors are not cleared correctly. An error `Validation failed: no DTD found !` occurs in libxml errors after parsing and it's available outside the xliff parser (can break other functionality that use `libxml_get_errors` function). Commits ------- fab61ef [Translation] [Config] Clear libxml errors after parsing XML file
… getOutput()) (YevKov) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#11986). Discussion ---------- typo fixed in AbstractProcessTest (getoutput() => getOutput()) Commits ------- 36998bb typo fixed in AbstractProcessTest (getoutput() => getOutput())
…from folder name in test to prevent windows file system issues. (Adam) This PR was merged into the 2.3 branch. Discussion ---------- [Finder][Urgent] Remove asterisk and question mark from folder name in test to prevent windows file system issues. Bugfix: Yes Fixed tickets: symfony#11984 , symfony#11985 Related tickets: symfony#11970 Commit symfony#11970 prevented Symphony from being checked out via windows due to invalid characters in a folder name within the tests. The issue was reported in symfony#11984 and was attempted to be fixed in symfony#11985 but wasn't due to still including the question mark. Please accept this ASAP as it entirely breaks any composer that relies on it. Commits ------- 5fbb278 Avoid question mark and asterisk in folder names to prevent windows filesystem issues.
…than Last-Modified
…ed-Since is later than Last-Modified (skolodyazhnyy) This PR was submitted for the master branch but it was merged into the 2.3 branch instead (closes symfony#11079). Discussion ---------- Response::isNotModified returns true when If-Modified-Since is later than Last-Modified | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | symfony#10501, symfony#10857 | License | MIT | Doc PR | Patch for symfony#10501. I have reworked a bit `Response::isNotModified` method to make it more readable. Now it's comparing If-Modified-Since and Last-Modified as dates. Commits ------- 42ec76e Response::isNotModified returns true when If-Modified-Since is later than Last-Modified
…Czris) This PR was merged into the 2.3 branch. Discussion ---------- [WebProfilerBundle] turbolinks compatibility | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | no | Fixed tickets | - | License | MIT | Doc PR | - Fix profiler when using turbolinks. (Without this, profiler is rendered without assets) Commits ------- c65b4c7 [WebProfilerBundle] turbolinks compatibility
…ints not to be required
3bbd12f to
b521caf
Compare
|
Replaced by #12004. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is WIP and should not yet be merged. It is one of two alternative solutions to #6645. The other alternative is to stepwisely set the default value of the
requiredoption tofalse, as described in #6645.