[EventDispatcher] don't count empty listeners #11475
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
| @@ -82,7 +82,7 @@ public function getListeners($eventName = null) | |||
| */ | |||
| public function hasListeners($eventName = null) | |||
| { | |||
| return (bool) count($this->getListeners($eventName)); | |||
| return (bool) count(array_filter($this->getListeners($eventName))); | |||
There was a problem hiding this comment.
Should we still return empty listeners in getListeners()?
There was a problem hiding this comment.
No, I guess that doesn't make any sense, does it? So, moving the filter to getListeners() would be better I think.
There was a problem hiding this comment.
I moved the array_filter() call.
|
Please note that by moving the array_filter() from my proposed solution in the return value of getListeners() to hasListeners() still makes getListeners() return empty arrays... |
| public function testGetListenersWhenAddedCallbackListenerIsRemoved() | ||
| { | ||
| $listener = function () { | ||
| }; |
There was a problem hiding this comment.
Could you define this (and previous) anonymous function in a single line. At the moment looks a bit odd.
When event listeners for certain events are removed from the event dispatcher, empty arrays are not being removed. Therefore, counting on empty arrays leads to wrong results of the hasListeners() method.
|
👍 |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 27, 2014
This PR was merged into the 2.3 branch. Discussion ---------- [EventDispatcher] don't count empty listeners | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #11444 | License | MIT | Doc PR | When event listeners for certain events are removed from the event dispatcher, empty arrays are not being removed. Therefore, counting on empty arrays leads to wrong results of the hasListeners() method. Thanks to @mlindenb for discovering this an proposing a solution. Commits ------- fdbb04a [EventDispatcher] don't count empty listeners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When event listeners for certain events are removed from the event
dispatcher, empty arrays are not being removed. Therefore, counting
on empty arrays leads to wrong results of the hasListeners() method.
Thanks to @mlindenb for discovering this an proposing a solution.