[Finder] Avoid asterisk in the file path to prevent windows filesystems problems #11985
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ms problems. The other characters in the directory name are sufficient to verify the name is escaped.
|
I believe the question mark (?) is also an issue. |
|
As noted by @phazei, the '?' is, indeed also a problem. Looks like I got no errors, but also the directory was not created, maybe because I was using 4NT instead of CMD? But now I'm receiving the error on both, so the '?' will have to go too. I tried to create it via cifs (Linux connected to Windows) too and got the same error. |
This was referenced Sep 23, 2014
|
Closing in favor of #11989 |
fabpot
added a commit
that referenced
this pull request
Sep 23, 2014
…lder name in test to prevent windows file system issues. (Adam) This PR was merged into the 2.3 branch. Discussion ---------- [Finder][Urgent] Remove asterisk and question mark from folder name in test to prevent windows file system issues. Bugfix: Yes Fixed tickets: #11984 , #11985 Related tickets: #11970 Commit #11970 prevented Symphony from being checked out via windows due to invalid characters in a folder name within the tests. The issue was reported in #11984 and was attempted to be fixed in #11985 but wasn't due to still including the question mark. Please accept this ASAP as it entirely breaks any composer that relies on it. Commits ------- 5fbb278 Avoid question mark and asterisk in folder names to prevent windows filesystem issues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
*in directory name causes problems on windows. The other regexp characters in the directory name are sufficient to verify the name is escaped.