[2.3] Add missing development dependencies #11340
Conversation
| - php: 5.4 | ||
| env: components=yes | ||
| - php: 5.6 | ||
| env: components=yes |
There was a problem hiding this comment.
instead of using lots of excludes, I would use an include rule instead (you forgot to exclyde the HHVM builds here for instance)
|
Thanks for the tip @stof, PR has been updated |
|
|
||
| services: mongodb | ||
|
|
||
| env: | ||
| - components=yes | ||
| - components=no |
There was a problem hiding this comment.
you can simplify this:
env:
global:
- components=no
matrix:
include:
- php: 5.5
env: components=yes
this avoids excluding the components=yes from the build
|
thanks again @stof ! PR has been upadted |
| "symfony/finder": "~2.0", | ||
| "symfony/security": "~2.3", | ||
| "symfony/form": "~2.3", | ||
| "symfony/form": "~2.3.0", |
There was a problem hiding this comment.
This looks wrong IMO, IIRC you will lock the FrameworkBundle with 2.3.x versions, and not allow any newer.
There was a problem hiding this comment.
This is actually needed on branch 2.3 - latest versions of the form component are not compatible anymore. We'll have to update this dependency in other branches after merge
|
Is it ready to be merged? |
|
ping @romainneutron |
|
Yes it is, ping @symfony/deciders |
| - echo "Running tests requiring tty"; phpunit --group tty | ||
| - sh -c 'if [ "$components" = "no" ]; then sh -c "ls -d src/Symfony/*/* | parallel --gnu --keep-order '\''echo \"Running {} tests\"; phpunit --exclude-group tty,benchmark {};'\''"; fi;' | ||
| - sh -c 'if [ "$components" = "no" ]; then sh -c "echo "\""Running tests requiring tty"\""; phpunit --group tty"; fi;' | ||
| - sh -c 'if [ "$components" = "yes" ]; then sh -c "find src/Symfony -mindepth 3 -maxdepth 3 -type f -name '\''phpunit.xml.dist'\'' | sed '\''s#\(.*\)/.*#\1#'\'' | parallel --gnu --keep-order '\''echo \"Running {} tests\"; cd {}; COMPOSER_ROOT_VERSION=dev-master composer --prefer-source --dev install; phpunit --exclude-group tty,benchmark;'\''"; fi;' |
There was a problem hiding this comment.
are you sure about -mindepth 3 -maxdepth 3 ? The security/core, security/http, security/csrf and security/acl components are at a deeper level than other components
448ed92 to
945fb9b
Compare
60b3413 to
3c742b7
Compare
|
PR updated and comments addressed. Build is still failing because HttpFoundation master in not sync'd anymore with current master (@fabpot alerted) After fixing this issue, test will pass and this PR should be mergeable |
|
@romainneutron the HttpFoundation split has been fixed now. |
|
@romainneutron Can you trigger another build on Travis? |
|
@fabpot I just triggered it :) https://travis-ci.org/symfony/symfony/builds/35861815 |
3c742b7 to
0ca153b
Compare
|
Thank you @romainneutron. |
This PR was squashed before being merged into the 2.3 branch (closes #11340). Discussion ---------- [2.3] Add missing development dependencies | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT I've also added a run of the test suite in every component scope. Commits ------- 3b02af9 [2.3] Add missing development dependencies
|
I see an issue here: for PRs introducing new features in several components, this could fail because subtree splits will not be updated until the PR is merged. Should we avoid running these tests in PRs ? |
…nneutron) This PR was squashed before being merged into the 2.3 branch (closes symfony#11340). Discussion ---------- [2.3] Add missing development dependencies | Q | A | ------------- | --- | Bug fix? | no | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | n/a | License | MIT I've also added a run of the test suite in every component scope. Commits ------- 3b02af9 [2.3] Add missing development dependencies
I've also added a run of the test suite in every component scope.