-
-
Notifications
You must be signed in to change notification settings - Fork 9.6k
[2.3] Add missing development dependencies #11340
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -29,11 +29,15 @@ | |
"doctrine/common": "~2.2" | ||
}, | ||
"require-dev": { | ||
"symfony/browser-kit": "~2.3", | ||
"symfony/console": "~2.0", | ||
"symfony/finder": "~2.0", | ||
"symfony/security": "~2.3", | ||
"symfony/form": "~2.3", | ||
"symfony/form": "~2.3.0", | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This looks wrong IMO, IIRC you will lock the FrameworkBundle with There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. This is actually needed on branch 2.3 - latest versions of the form component are not compatible anymore. We'll have to update this dependency in other branches after merge |
||
"symfony/class-loader": "~2.1", | ||
"symfony/validator": "~2.1" | ||
"symfony/process": "~2.0", | ||
"symfony/validator": "~2.1", | ||
"symfony/yaml": "~2.0" | ||
}, | ||
"suggest": { | ||
"symfony/console": "", | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
instead of using lots of excludes, I would use an
include
rule instead (you forgot to exclyde the HHVM builds here for instance)