8000 Missed composer dependencies in Symfony Components · Issue #11620 · symfony/symfony · GitHub
[go: up one dir, main page]
Skip to content
8000

Missed composer dependencies in Symfony Components #11620

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
max-voloshyn opened this issue Aug 8, 2014 · 6 comments
Closed

Missed composer dependencies in Symfony Components #11620

max-voloshyn opened this issue Aug 8, 2014 · 6 comments

Comments

@max-voloshyn
Copy link
Contributor

From time to time I see PR that fixes composer.json for concrete component.
I assume that these failures are happening because each component is not tested by Travis CI as standalone project.
Thus missed composer dependencies in concrete component are usually found by people, not Travis CI.
Maybe each component has to have own .travis.yml and Travis CI should test each component via relevant mirror repository?

P.S. Feel free to close this issue if you think that it is not worth it. Just suggestion.
@stof
Copy link
Member
stof commented Aug 8, 2014

Givent aht Travis allows only a few concurrent jobs per github organization (approx 5 but the exact value may depend on their server load), running jobs for each pushes to the subtree split repos would mean that each time the subtree are updated, the builds of the main repo will not be processed during a long time (until all subtrees have been built). IMO, the drawbacks outfit the advantages here.

@stof
Copy link
Member
stof commented Aug 8, 2014

thus, what is missing most of the time are require-dev dependencies, not hard requirement, which affects only people running the testsuite of the standalone component, not people using the components. And this does not happen so much, given that you are not supposed to develop in standalone components directly but in the fullstack repo.

@max-voloshyn
Copy link
Contributor Author

Missed dependency is one case, another case is wrong version of hard dependency.

Anyway, @stof , thanks for the reply, I don't knew these details about Travis CI, so drawbacks may be really bigger than advantages...

@stof
Copy link
Member
stof commented Aug 8, 2014

A wrong version is hard to detect, because the common mistake is to forget to bump the requirement when depending on a new feature. But given that composer will use the latest version matching the requirement, you won't see the error when running the testsuite. You will only see it when installing it alongside another package forcing to use an older version of the dependency

@stof
Copy link
Member
stof commented Aug 18, 2014

https://github.com/symfony/symfony/pull/11340/files is adding a run of the testsuite at the component level on Travis, which should avoid such mistakes in the future

@max-voloshyn
Copy link
Contributor Author

Looks like #11340 really solves this problem. Thanks 6467 @stof, @romainneutron

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@stof @max-voloshyn
0