[Form] Fixed ValidatorTypeGuesser to guess properties without constraints not to be required #12004
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
b521caf to
2571828
Compare
|
Isn't it a BC break? |
|
@fabpot I don't think so. Before, when a field had no constraint, the "required" option was set to |
|
Got it now. 👍 |
| 2.3.20 | ||
| ------ | ||
|
|
||
| * the validator guesser guesses fields for properties without any constraints |
There was a problem hiding this comment.
should be removed as the changelogs for minor versions are auto-generated.
…ints not to be required
2571828 to
fd77b09
Compare
|
Thank you @webmozart. |
fabpot
added a commit
that referenced
this pull request
Sep 24, 2014
…out constraints not to be required (webmozart) This PR was merged into the 2.3 branch. Discussion ---------- [Form] Fixed ValidatorTypeGuesser to guess properties without constraints not to be required | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | #6645 | License | MIT | Doc PR | - Consider the following entity: ```php class Author { /** * @Assert\NotBlank */ private $name; private $age; } ``` Right now, the "required" HTML attribute is set for both fields (since the default value of the "required" option is true). IMO this is wrong. With this fix, the ValidatorTypeGuesser guesses `false` for the "required" option unless a NotNull/NotBlank constraint is present. Commits ------- fd77b09 [Form] Fixed ValidatorTypeGuesser to guess properties without constraints not to be required
|
@webmozart wasn't this fixed already in #3821 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Consider the following entity:
Right now, the "required" HTML attribute is set for both fields (since the default value of the "required" option is true). IMO this is wrong.
With this fix, the ValidatorTypeGuesser guesses
falsefor the "required" option unless a NotNull/NotBlank constraint is present.