[Form] Fixed required value guessed by ValidatorTypeGuesser #3821
Conversation
Commits ------- e0ce6b4 [Form] Fixed required value guessed by ValidatorTypeGuesser Discussion ---------- [Form] Fixed required value guessed by ValidatorTypeGuesser Bug fix: yes Feature addition: no Backwards compatibility break: no* Symfony2 tests pass: yes Fixes the following tickets: #3661 Todo: -  The documentation states that a field is set to required if constrained with NotBlank or NotNull and to not required otherwise. Due to a bug this was not the case and fields were always required. This is now fixed. The consequence is that some fields that were required before by default are not required anymore. The only difference is that the HTML5 "required" attribute disappears, because server-side validation did not occur before anyway.
|
This was merged to 2.1 but not 2.0 . Is there a particular reason or should I try with a pull request for 2.0 ? |
|
Hm, for some reason all my fields still have the required="required" attribute rendered when I don't explicitely set this attribute to false (in latest 2.1). So it doesn't matter what the constraints are or if there are none. |
|
Ok I know why, as stated in the doc:
|
|
I dislike that the default for required is true, as such extra functionality like HTML5 validation should be opt-in and not opt-out. Also it's quite inconsistent as client-side the default is required but on the server side the default is non-required. |
|
+1, @Tobion |
Bug fix: yes
Feature addition: no
Backwards compatibility break: no*
Symfony2 tests pass: yes
Fixes the following tickets: #3661
Todo: -
The documentation states that a field is set to required if constrained with NotBlank or NotNull and to not required otherwise. Due to a bug this was not the case and fields were always required. This is now fixed.
The consequence is that some fields that were required before by default are not required anymore. The only difference is that the HTML5 "required" attribute disappears, because server-side validation did not occur before anyway.