remove unused imports #11484
Merged
remove unused imports #11484
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
| Q | A |
|---|---|
| Bug fix? | yes |
| New feature? | no |
| BC breaks? | no |
| Deprecations? | no |
| Tests pass? | yes |
| Fixed tickets | |
| License | MIT |
| Doc PR |
| @@ -12,7 +12,6 @@ | |||
| namespace Symfony\Bridge\Doctrine; | |||
|
|
|||
| use Doctrine\Common\Persistence\ManagerRegistry as ManagerRegistryInterface; | |||
| use Doctrine\ORM\Configuration; | |||
There was a problem hiding this comment.
Oh, you're right. I missed that. What is the usual practice for this? Do we keep the use statement or should I modify the docblock to use the fully qualified class name?
There was a problem hiding this comment.
imo, keep the use statement
We are using use statements for everything including the phpdocs.
|
Reverted the two changes mentioned by @jakzal. |
|
Thank you @xabbuh. |
fabpot
added a commit
that referenced
this pull request
Jul 27, 2014
This PR was merged into the 2.3 branch. Discussion ---------- remove unused imports | Q | A | ------------- | --- | Bug fix? | yes | New feature? | no | BC breaks? | no | Deprecations? | no | Tests pass? | yes | Fixed tickets | | License | MIT | Doc PR | Commits ------- 9cd059e remove unused imports
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.