8000 Release 0.20.2 by amueller · Pull Request #12784 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

Release 0.20.2 #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 41 commits into from
Dec 18, 2018
Merged

Release 0.20.2 #12784

merged 41 commits into from
Dec 18, 2018

Conversation

amueller
Copy link
Member
@amueller amueller commented Dec 14, 2018 •
edited
Loading

Doesn't include #12659 which I think was added to 0.20.2 by mistake.
Still missing #12701.

Requires adding contributors and release date as well.

@amueller amueller changed the base branch from master to 0.20.X December 14, 2018 16:48
@amueller amueller closed this Dec 14, 2018
@amueller amueller reopened this Dec 14, 2018
@qinhanmin2014
Copy link
Member

@amueller Circle CI is not running
101ddb3
3cb4a52 shouldn't be here
These are hot fixes after we remove CI < python 3.5

@amueller
Copy link
Member Author

@jnothman maybe you can tell me how you're doing the rebase now ;)
I tried running the same rebase again but looks like everything that I dropped shows up again as pick.

qinhanmin2014 and others added 24 commits December 17, 2018 15:26
@qinhanmin2014 @amueller
DOC update news, make 0.20 link to 0.20.0
3794afa
@amueller
don't set check_pickle on new joblib on python2.7 (scikit-learn#12645)
4a4a73e
@qinhanmin2014 @amueller
DOC Add contributors for 0.20.1
677aa51
@amueller
Doc: minor word change (scikit-learn#12646)
e986630
@amueller
DOC fix minor sphinx issues (scikit-learn#12653)
df30586
@jorisvandenbossche @amueller
DOC: start section for the 0.20.2 bugfix notes (scikit-learn#12664)
eea0a28
@albertcthomas @amueller
DOC Fix links in anomaly detection example (scikit-learn#12665)
7e306a3
@lesteve @amueller
EXA remove unused variables. (scikit-learn#12647)
498e45f 
The data comes from static CSVs that cover 2003-01-01 to 2007-12-31.
@qinhanmin2014 @amueller
MNT Unused import
2904920
@NicolasHug @amueller
[MRG] Fixed randomness of test_logreg_cv_penalty (scikit-learn#12624)
03ac360 
* fixed randomness of test_logreg_cv_penalty

* Added comment about warm-starting coefficients
@samwaterbury @amueller
DOC Updated MLP partial_fit documentation (scikit-learn#12618)
a0005da
@ogrisel @amueller
DOC use twine to upload wheels to pypi (scikit-learn#12661)
c24e63e
@josephsalmon @amueller
EXA improving examples/mixture/plot_gmm_covariances.py visualisation (s…
039f365 
…cikit-learn#12683)
@qinhanmin2014 @amueller
TST Specify random seed in test_shuffle_kfold_stratifiedkfold_reprodu…
6c1703f 
…cibility (scikit-learn#12674)
@adrinjalali @amueller
DOC add joblib to doc-build deps (scikit-learn#12691)
676bf9b
@thomasjpfan @amueller
FIX Adapts cdist jaccard to scipy 1.2.0 (scikit-learn#12692)
caf652f
@shivam-kotwalia @amueller
DOC Fix joblib URL (scikit-learn#12698)
4822a19
@qinhanmin2014 @amueller
MNT Minor code refactoring in utils.testing (scikit-learn#12688)
dc5359f
@dstine @amueller
DOC Update TfidfVectorizer analyzer documentation to match CountVecto…
e9f0c1d 
…rizer (scikit-learn#12713)
@qinhanmin2014 @amueller
FIX Fix error in make_column_transformer when columns is pandas.Index (…
b1471d2 
…scikit-learn#12704)

Fixes scikit-learn#12703
@jorisvandenbossche @amueller
BUG: fix check_array on pandas Series with custom dtype (eg categoric…
765f3e4 
…al) (scikit-learn#12706)

Closes scikit-learn#12699. Related to scikit-learn#12625
@jnothman @amueller
DOC regenerate authors.rst after Adrin has joined (scikit-learn#12719)
3af7147
@adrinjalali @amueller
EXA change normed to density in matplotlib calls in examples (scikit-…
9d9d798 
…learn#12718)
@JanSellner @amueller
DOC Clarify what the decision function in SVM calculates (scikit-lear…
fdfba9d 
…n#12708)
albertcthomas and others added 6 commits December 17, 2018 15:26
@albertcthomas @amueller
DOC change "cumulative density" to "cumulative distribution" (scikit-…
ea36f6e 
…learn#12754)
@NicolasHug @amueller
DOC Added roadmap.rst (scikit-learn#12761)
908898b
@hassaanseeker @amueller
Update linear_model.rst (scikit-learn#12735)
d3664b6 
* Update for Logistic-Regression Table Summary for L-BFGS

* Update for linear_model.rst Logistic-Regression L-BFGS summary.

* Update for Logistic-Regression Doc.

* Logistic-Regression Update

* Update linear_model.rst

* Update jnothman comments

* Update jnothman comments

* Update for jnothman comments.

* test

* test2

* test3

* test4

* Update for Comments from amueller and jnothman

* Update for Comments from amueller and jnothman
@amueller
DOC Explain solver choices for LogisticRegression (scikit-learn#12768)
44a0c80
@qinhanmin2014 @amueller
MNT flake8 in r2_score examples (scikit-learn#12773)
c51fd04
@dafeda @amueller
EXA Avoiding TypeError when using --all_categories in plot_document_c…
9ad9847 
…lassification_20newsgroups.py (scikit-learn#12770)
@amueller
Copy link
Member Author

Good to go?
#12671 (which was a major driver for doing another release) will hopefully be fixed as part of the release process.

@jnothman
Copy link
Member

You've not updated __version__

@jnothman
Copy link
Member

I tried running the same rebase again but looks like everything that I dropped shows up again as pick.

Yes, it does, but it's all at the beginning of the rebase list and so easy to change to drop in one go.

qinhanmin2014
qinhanmin2014 approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, I've opened #12810

@qinhanmin2014
Copy link
Member

And we need to add 5ab850a to master.

@h6197627
Copy link

Hi,
#12676 won't be fixed in this release?

@jnothman
Copy link
Member

@h6197627 it's impossible to fix every bug in some release. It's also difficult to fix a bug if we can't reproduce it. I suspect the answer is no, #12676 won't be fixed until we can reproduce and diagnose it. 0.20 was also so big a release that it's hard to even guess what might have caused this (except that #10071 appears to be the only change directly touching OMP)

@jnothman
Copy link
Member

And we need to add 5ab850a to master.

Yes, ideally this would be pushed to master first

@qinhanmin2014
Copy link
Member

@jnothman I guess we need #12810 ? (and maybe #12816 ?)

@jnothman jnothman merged commit a941c2e into scikit-learn:0.20.X Dec 18, 2018
@jnothman
Copy link
Member

merging for release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@qinhanmin2014 qinhanmin2014 qinhanmin2014 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
0