8000 TST np.vstack won't support generator in the future by qinhanmin2014 · Pull Request #12816 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]
Skip to content

TST np.vstack won't support generator in the future #12816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 18, 2018
Merged

TST np.vstack won't support generator in the future #12816

merged 1 commit into from
Dec 18, 2018

Conversation

qinhanmin2014
Copy link
Member
@qinhanmin2014 qinhanmin2014 commented Dec 18, 2018 •
edited
Loading

Travis cron job failure introduced in #12701
Maybe hurry into 0.20.2 ping @jeremiedbb @jnothman @amueller
8000

@jeremiedbb
Copy link
Member

Sorry I forgot about that :/
It seems that it was slower than stacking after making it a tuple so it's better this way anyway.

LGTM

@qinhanmin2014 qinhanmin2014 mentioned this pull request Dec 18, 2018
Merged
@adrinjalali adrinjalali merged commit 5b4cffd into scikit-learn:master Dec 18, 2018
@qinhanmin2014 qinhanmin2014 deleted the pairwise-test branch December 18, 2018 14:51
jnothman pushed a commit to amueller/scikit-learn that referenced this pull request Dec 18, 2018
@qinhanmin2014 @jnothman
TST np.vstack won't support generator in the future (scikit-learn#12816)
8da0d23
adrinjalali pushed a commit to adrinjalali/scikit-learn that referenced this pull request Jan 7, 2019
@qinhanmin2014 @adrinjalali
TST np.vstack won't support generator in the future (scikit-learn#12816)
34b812a
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
@qinhanmin2014
TST np.vstack won't support generator in the future (scikit-learn#12816)
f55087d
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "TST np.vstack won't support generator in the future (scikit-l…
bb43e2e 
…earn#12816)"

This reverts commit f55087d.
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
Revert "TST np.vstack won't support generator in the future (scikit-l…
1898810 
…earn#12816)"

This reverts commit f55087d.
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
@qinhanmin2014 @koenvandevelde
TST np.vstack won't support generator in the future (scikit-learn#12816)
ee64f35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jnothman jnothman jnothman approved these changes

@adrinjalali adrinjalali adrinjalali approved these changes

@jeremiedbb jeremiedbb jeremiedbb approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@qinhanmin2014 @jeremiedbb @jnothman @adrinjalali
0