Update linear_model.rst #12735
Merged
Update linear_model.rst #12735
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jnothman
approved these changes
Dec 9, 2018
eamanu
approved these changes
Dec 10, 2018
|
thx @hassaanseeker |
amueller
reviewed
Dec 13, 2018
| @@ -814,7 +818,7 @@ each solver: | |||
| +------------------------------+-----------------+-------------+-----------------+-----------+------------+ | |||
|
|
|||
| The "saga" solver is often the best choice but requires scaling. The | |||
| "liblinear" solver is used by default for historical reasons. | |||
| "lbfgs" solver is used by default for historical reasons. | |||
There was a problem hiding this comment.
Err... that's pretty wrong. We just moved to that solver. It's used because it's a great default!
There was a problem hiding this comment.
Ok i just changed the solver as the lbfgs explanation above plus the reference links say that it is good in some scenarios. So i need to update only that its being used as it is the best default.
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 14, 2018
* Update for Logistic-Regression Table Summary for L-BFGS * Update for linear_model.rst Logistic-Regression L-BFGS summary. * Update for Logistic-Regression Doc. * Logistic-Regression Update * Update linear_model.rst * Update jnothman comments * Update jnothman comments * Update for jnothman comments. * test * test2 * test3 * test4 * Update for Comments from amueller and jnothman * Update for Comments from amueller and jnothman
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 17, 2018
* Update for Logistic-Regression Table Summary for L-BFGS * Update for linear_model.rst Logistic-Regression L-BFGS summary. * Update for Logistic-Regression Doc. * Logistic-Regression Update * Update linear_model.rst * Update jnothman comments * Update jnothman comments * Update for jnothman comments. * test * test2 * test3 * test4 * Update for Comments from amueller and jnothman * Update for Comments from amueller and jnothman
adrinjalali
pushed a commit
to adrinjalali/scikit-learn
that referenced
this pull request
Jan 7, 2019
* Update for Logistic-Regression Table Summary for L-BFGS * Update for linear_model.rst Logistic-Regression L-BFGS summary. * Update for Logistic-Regression Doc. * Logistic-Regression Update * Update linear_model.rst * Update jnothman comments * Update jnothman comments * Update for jnothman comments. * test * test2 * test3 * test4 * Update for Comments from amueller and jnothman * Update for Comments from amueller and jnothman
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
* Update for Logistic-Regression Table Summary for L-BFGS * Update for linear_model.rst Logistic-Regression L-BFGS summary. * Update for Logistic-Regression Doc. * Logistic-Regression Update * Update linear_model.rst * Update jnothman comments * Update jnothman comments * Update for jnothman comments. * test * test2 * test3 * test4 * Update for Comments from amueller and jnothman * Update for Comments from amueller and jnothman
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 9a751f3.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
This reverts commit 9a751f3.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
* Update for Logistic-Regression Table Summary for L-BFGS * Update for linear_model.rst Logistic-Regression L-BFGS summary. * Update for Logistic-Regression Doc. * Logistic-Regression Update * Update linear_model.rst * Update jnothman comments * Update jnothman comments * Update for jnothman comments. * test * test2 * test3 * test4 * Update for Comments from amueller and jnothman * Update for Comments from amueller and jnothman
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You
2D01
must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
Fixes #12617
Closes #12663
What does this implement/fix? Explain your changes.
Update for lbfgs(Logistic-Regression) solver for linear_model.rst documentation.
Any other comments?