[MRG] improving examples/mixture/plot_gmm_covariances.py visualisation #12683
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
eamanu
approved these changes
Nov 27, 2018
agramfort
approved these changes
Nov 27, 2018
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 14, 2018
amueller
pushed a commit
to amueller/scikit-learn
that referenced
this pull request
Dec 17, 2018
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…isation (scikit-learn#12683)" This reverts commit 6ca934a.
xhluca
pushed a commit
to xhluca/scikit-learn
that referenced
this pull request
Apr 28, 2019
…isation (scikit-learn#12683)" This reverts commit 6ca934a.
koenvandevelde
pushed a commit
to koenvandevelde/scikit-learn
that referenced
this pull request
Jul 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reference Issues/PRs
This is a one line patch to make ratio equals when visualizing the four plots in plot_gmm_covariances.py.
Before the patch, the "spherical" case is visualized in a way that make the covariances appear non-spherical (top left image). This is confusing w.r.t. the name of the plot, and could lead to users misunderstanding.
What does this implement/fix? Explain your changes.
Adding the following line:
ax.set_aspect('equal', 'datalim')
solved the problem, and make spheres appearing as spheres (not as ellipsoids) where needed. Also this improved readability of the global figure.