8000 update TfidfVectorizer analyzer documentation to match CountVectorizer by dstine · Pull Request #12713 · scikit-learn/scikit-learn · GitHub
[go: up one dir, main page]

Skip to content

update TfidfVectorizer analyzer documentation to match CountVectorizer #12713

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 3, 2018

Conversation

dstine
Copy link
Contributor
@dstine dstine commented Dec 2, 2018

Reference Issues/PRs

What does this implement/fix? Explain your changes.

This class TfidfVectorizer has the same analyzer options as CountVectorizer. This PR adds missing description and the char_wb option in particular to TfidfVectorizer.

Any other comments?

@dstine dstine changed the title update analyzer documentation to match CountVectorizer update TfidfVectorizer analyzer documentation to match CountVectorizer Dec 2, 2018
Copy link
Contributor
@eamanu eamanu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes that right

Copy link
Member
@qinhanmin2014 qinhanmin2014 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @dstine

@qinhanmin2014 qinhanmin2014 merged commit 92e8fc9 into scikit-learn:master Dec 3, 2018
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Dec 14, 2018
amueller pushed a commit to amueller/scikit-learn that referenced this pull request Dec 17, 2018
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
xhluca pushed a commit to xhluca/scikit-learn that referenced this pull request Apr 28, 2019
koenvandevelde pushed a commit to koenvandevelde/scikit-learn that referenced this pull request Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants
0